Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use Django with ASGI #1051

Open
owais opened this issue Apr 12, 2022 · 11 comments
Open

Document how to use Django with ASGI #1051

owais opened this issue Apr 12, 2022 · 11 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@owais
Copy link
Contributor

owais commented Apr 12, 2022

ASGI support for Django was added in the PR #391 but we never documented the usage.

Users may have to install opentelemetry-instrumentation-django[asgi] in order to take advantage of asgi support. This should be documented at https://opentelemetry-python-contrib.readthedocs.io/en/latest/instrumentation/django/django.html

@owais owais added feature-request documentation Improvements or additions to documentation good first issue Good for newcomers and removed feature-request labels Apr 12, 2022
@rahuldimri
Copy link
Contributor

@owais can I work on this ? Please assign this to me.

@rahuldimri
Copy link
Contributor

Thanks for assigning this to me. I am new to OpenSource community. If you can help me initially that would be great.
Just wanted to know do you have any template for updating the document ?.

@lzchen
Copy link
Contributor

lzchen commented Jul 29, 2022

You can make your doc addition to the docstrings of the django instrumentation. Your docs will be reflected in readthedocs if you do this. Follow the structuring and wording of the other types of configuration, I would name the header something like Asgi Configuration or something.

@Abhishek-569
Copy link

Abhishek-569 commented Apr 18, 2023

I want to work on this issue. Is there any example or use cases on what exactly ASGI support for Django help the users with in opentelemetry ?

@srikanthccv
Copy link
Member

Your question is unclear; how are "use cases" relevant to this issue?

@Abhishek-569
Copy link

Sorry if my question was not clear before. I am asking like this below for example on this page for Django instrumentation we have to give one example or use case for the proper documentation of using Django with asgi. Please tell me if something is wrong with my proposal as this is my first issue on this project.
image

@srikanthccv
Copy link
Member

EXCLUDE_URLS has examples since it's a configuration option. This issue is about documenting that Django instrumentation supports ASGI.

@Abhishek-569
Copy link

Okay. we should add this issue in this page, right?

@srikanthccv
Copy link
Member

Yes, you need to update the docstrings, but this issue is already assigned. @rahuldimri please unassign yourself if you are not working on this.

@rahuldimri rahuldimri removed their assignment Apr 21, 2023
@Abhishek-569
Copy link

Okay can tell me where I can learn more onHow to use Django with asgihelps in open-telemetry?

@baravkareknath
Copy link

Hi Abhishek-569 can you assign this documentation work to me if you are not working on the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants