From 5561b62fdcd2f106272c170f4bfa96000cb73078 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Thu, 11 Apr 2024 14:50:36 +0200 Subject: [PATCH] boostrap: no need to install tortoiseorm instrumentation if pydantic is found Not every user of pydantic is using tortoise orm so checking for tortoise orm should be enough. --- CHANGELOG.md | 3 +++ .../src/opentelemetry/instrumentation/bootstrap_gen.py | 4 ---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e5186ac7fa..2301c7247a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,9 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Unreleased + - `opentelemetry-sdk-extension-aws` Register AWS resource detectors under the `opentelemetry_resource_detector` entry point ([#2382](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2382)) +- `opentelemetry-instrumentation` On bootstrap don't install tortoise orm instrumentation if pydantic is found + ([#2409](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2409)) ### Breaking changes diff --git a/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py b/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py index 30a41b924a..6b65172598 100644 --- a/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py +++ b/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py @@ -176,10 +176,6 @@ "library": "tortoise-orm >= 0.17.0", "instrumentation": "opentelemetry-instrumentation-tortoiseorm==0.46b0.dev", }, - { - "library": "pydantic >= 1.10.2", - "instrumentation": "opentelemetry-instrumentation-tortoiseorm==0.46b0.dev", - }, { "library": "urllib3 >= 1.0.0, < 3.0.0", "instrumentation": "opentelemetry-instrumentation-urllib3==0.46b0.dev",