Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label keys/values in diagram in metrics.proto do not match the proto specification #124

Closed
rghetia opened this issue Mar 13, 2020 · 4 comments · Fixed by #178
Closed

Label keys/values in diagram in metrics.proto do not match the proto specification #124

rghetia opened this issue Mar 13, 2020 · 4 comments · Fixed by #178

Comments

@rghetia
Copy link

rghetia commented Mar 13, 2020

The diagram in metrics.proto does not match the specification.
Diagram indicates that Descriptor contains only Keys while the proto say it contains keys and values that are common to all data points.

@tigrannajaryan
Copy link
Member

Yes, @bogdandrutu changed the proto recently. The diagram needs an update.

@tigrannajaryan
Copy link
Member

If only I remembered what did I use to create the diagram :-)
Let me see if I can dig it.

@bogdandrutu
Copy link
Member

@tigrannajaryan let me know if you find how you created the diagram.

@tigrannajaryan
Copy link
Member

@bogdandrutu I think I used this https://textik.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants