Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[target-allocator] ServiceMonitor must rely on an empty job #963

Closed
CoderPoet opened this issue Jul 6, 2022 · 3 comments
Closed

[target-allocator] ServiceMonitor must rely on an empty job #963

CoderPoet opened this issue Jul 6, 2022 · 3 comments
Labels
area:target-allocator Issues for target-allocator

Comments

@CoderPoet
Copy link
Contributor

CoderPoet commented Jul 6, 2022

At present, when we use servicemonitor, we must set an empty job as a placeholder for config replace
eg:

    receivers:
      prometheus:
        config:
          scrape_configs:
          - job_name: serviceMonitor/vke-system/harbor-server/0

image

servicemonitor is dynamically created, so there is no way to preset an empty job. Can we consider generating these scrape job configurations automatically?

@CoderPoet
Copy link
Contributor Author

Is it possible to automatically generate this type of job without manual pre-creation

@jaronoff97
Copy link
Contributor

I believe this will be resolved by this PR which allows for dynamic jobs to be found by the prometheus receiver

@secustor
Copy link
Member

secustor commented Nov 3, 2022

Solved in Release v0.61.0

@secustor secustor closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants