Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tolerations? #186

Closed
markfink-splunk opened this issue Jan 31, 2021 · 1 comment · Fixed by #302
Closed

Add support for tolerations? #186

markfink-splunk opened this issue Jan 31, 2021 · 1 comment · Fixed by #302
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@markfink-splunk
Copy link

In daemonset mode, it installs to worker nodes only, not master, which is normal and we can usually workaround with a toleration. But I can't figure out how to apply a toleration to this operator and support for it may need to be added. The use-case is for the kubelet metrics receiver that is available with otel-collector-contrib. I'd like to get kubelet metrics on the master node. I'm creating a separate deployment just for the master now. It would be convenient to roll support for this into the operator.
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers and removed needs-triage labels Feb 1, 2021
@jpkrohling
Copy link
Member

Sounds like a valid use case. Would you like to send a PR adding support to the operator?

@VineethReddy02 VineethReddy02 mentioned this issue Jun 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tolerations support in otelcol CRD
2 participants
@jpkrohling @markfink-splunk