Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable receiver types to ignore when parsing ports #1095

Open
kristinapathak opened this issue Sep 13, 2022 · 5 comments
Open

Configurable receiver types to ignore when parsing ports #1095

kristinapathak opened this issue Sep 13, 2022 · 5 comments
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed

Comments

@kristinapathak
Copy link
Contributor

case name == "kubeletstats":
return nil
// ignore prometheus receiver as it has no listening endpoint
case name == "prometheus":
return nil

Currently, the receivers to skip are hard coded into the singlePortFromConfigEndpoint() function. Instead, we can make this configurable with kubeletstats and prometheus as the default list of receivers to skip.

This is from @secustor's comment:
#1070 (comment)

@pavolloffay pavolloffay added area:collector Issues for deploying collector help wanted Extra attention is needed labels Sep 15, 2022
@tania-anand
Copy link

Hi @kristinapathak can I take a look at this issue, if its not resolved.

@kristinapathak
Copy link
Contributor Author

Sounds great!

@tania-anand
Copy link

@kristinapathak is it okay to add config with name skip_receivers with type as array of strings in config file

@secustor
Copy link
Member

This should be part of the Collector CRD.

I suggest ports_ignore_receivers as ports already explains that the config will be used to extract ports.

@fredthomsen
Copy link

This is an issue for my team as well. Happy to take it on if @tania-anand has gotten bogged down with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants