From 781107576afbdae37ac239e1b11b2ffa1c2596f9 Mon Sep 17 00:00:00 2001 From: "Pavan Sai Vasireddy (Vasi)" Date: Thu, 5 May 2022 15:39:22 -0700 Subject: [PATCH] improv --- collector/collector.go | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/collector/collector.go b/collector/collector.go index f78fc4abf8..a2ebe43f57 100644 --- a/collector/collector.go +++ b/collector/collector.go @@ -17,15 +17,15 @@ package main import ( "context" "fmt" + "log" + "os" + + "go.opentelemetry.io/collector/component" "go.opentelemetry.io/collector/config" "go.opentelemetry.io/collector/config/mapconverter/expandmapconverter" "go.opentelemetry.io/collector/config/mapprovider/envmapprovider" "go.opentelemetry.io/collector/config/mapprovider/filemapprovider" "go.opentelemetry.io/collector/config/mapprovider/yamlmapprovider" - "log" - "os" - - "go.opentelemetry.io/collector/component" "go.opentelemetry.io/collector/service" ) @@ -57,9 +57,9 @@ func getConfig() string { } func NewCollector(factories component.Factories) *Collector { + providers := []config.MapProvider{filemapprovider.New(), envmapprovider.New(), yamlmapprovider.New()} + mapProvider := make(map[string]config.MapProvider, len(providers)) - providers := []config.MapProvider{filemapprovider.New(), envmapprovider.New(), yamlmapprovider.New()} - mapProvider := make(map[string]config.MapProvider, len(providers)) for _, provider := range providers { mapProvider[provider.Scheme()] = provider } @@ -69,14 +69,16 @@ func NewCollector(factories component.Factories) *Collector { MapProviders: mapProvider, MapConverters: []config.MapConverterFunc{expandmapconverter.New()}, } - cfgProvider,err := service.NewConfigProvider(cfgSet) + cfgProvider, err := service.NewConfigProvider(cfgSet) + + if err != nil { + log.Panicf("error on creating config provider: %v\n", err) + } + col := &Collector{ factories: factories, configProvider: cfgProvider, } - if err != nil{ - log.Panicf("error on creating config provider: %v\n" ,err) - } return col }