-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of api.SpanAttributes
with api.Attributes
#2674
Comments
I vote yes. I guess we cannot avoid that, but wondering what problems users might face. |
I looked again and the change in api package is only in types, so it for sure expected to work in user code. |
Ah i didn't make it clear from the issue description this was something we already agreed upon, I just copied the original message from the previous thread |
Hi, Thanks! |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@RazGvili are you still planning to work on this? The 1.1 API was released |
This is fixed by #2881 |
LGTM. Since we are marking
SpanAttributes
as deprecated, should we have a follow up task to replace usage withAttributes
?Originally posted by @mwear in open-telemetry/opentelemetry-js-api#142 (review)
The text was updated successfully, but these errors were encountered: