-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript compatiblitly #2329
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stale for 14 days with no activity. |
I'd believe we can set up alternative CI for the latest and older typescript versions for 1. testing generated d.ts compatibility, 2. source code compatibility. (1) should be the most common one since most consumers depend on the published d.ts files. (2) might not be that popular option since we didn't publish the ts source files anyway. As TypeScript generally releases every 3 months, I'd believe supporting the latest 2-4 versions should cover 6 months of upgrading period. For above (1) and (2), I suppose we can apply different rules for them: (This is just a possible solution)
For version bumping, #3314 our cadence of release should be considered. I don't see another major version bump will happen in the near future, but we have to let go of the older typescript versions. |
TypeScript supports specifying different downlevel-dts rewrites |
Closed in favor of #4870 |
Followup on open-telemetry/opentelemetry-js-contrib#549 (comment)
Currently we use the latest version of typescript in our CI setup and we also use the latest features like
override
keyword. Besides such "visible" features likeoverride
there are also more hidden features like better type deduction,... which would result in problems if people try to use an older version.If someone would like to consume the raw TS files the same, new typescript version is needed which if often challenging.
As of now it should be no problem for consumers of transpiled packages but I'm not sure if there is a gurantee from TS side regarding this compatiblity.
@MSNev indicates that they would prefer a more conservative approach regarding this.
I think this is a valid point to consider. But if we decide to go this way I think following points should be done:
The text was updated successfully, but these errors were encountered: