From 9e8279fc69a6cbf198c825b811e4900bd43ccf60 Mon Sep 17 00:00:00 2001
From: Martin Kuba <martin@martinkuba.com>
Date: Thu, 16 Mar 2023 14:12:05 -0700
Subject: [PATCH] docs: updated example in README to match updated start method
---
CHANGELOG.md | 2 ++
experimental/packages/opentelemetry-sdk-node/README.md | 6 +-----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4b7418f59c5..5fbc1096862 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
### :books: (Refine Doc)
+* doc(sdk): update NodeSDK example [#3684](https://github.com/open-telemetry/opentelemetry-js/pull/3684) @martinkuba
+
### :house: (Internal)
## 1.10.0
diff --git a/experimental/packages/opentelemetry-sdk-node/README.md b/experimental/packages/opentelemetry-sdk-node/README.md
index 693f91ae742..2e093089583 100644
--- a/experimental/packages/opentelemetry-sdk-node/README.md
+++ b/experimental/packages/opentelemetry-sdk-node/README.md
@@ -58,11 +58,7 @@ const sdk = new opentelemetry.NodeSDK({
// See the Configuration section below for additional configuration options
});
-// You can optionally detect resources asynchronously from the environment.
-// Detected resources are merged with the resources provided in the SDK configuration.
-sdk.start().then(() => {
- // Resources have been detected and SDK is started
-});
+sdk.start();
// You can also use the shutdown method to gracefully shut down the SDK before process shutdown
// or on some operating system signal.