Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS SDK Instrumentation #323

Closed
willarmiros opened this issue Jan 27, 2021 · 7 comments
Closed

Add AWS SDK Instrumentation #323

willarmiros opened this issue Jan 27, 2021 · 7 comments
Labels
instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@willarmiros
Copy link
Contributor

Describe the solution you'd like
I would like there to be an instrumentation package for the AWS SDK, so that requests made with AWS SDK V2 (and the recently GA'd V3) can be traced with relevant metadata recorded.

Describe alternatives you've considered
I considered opening this as a plugin request, but I'm not sure what the formal definition of a plugin vs. an instrumentation library, especially with all the open issues to convert existing plugins to instrumentation packages. Regardless, I think this would be a widely-used and useful library.

Additional context
The Java OTel repo has already implemented AWS SDK instrumentation for reference. Also somewhat relevant are some of the attributes that could be recorded laid out in this spec PR (I know it's unattended but it should be picked back up and merged eventually).

@weyert
Copy link

weyert commented Jan 27, 2021

What about Azure and GCP SDKs?

@willarmiros
Copy link
Contributor Author

@weyert I think instrumentation for those could be tracked in separate issues. This is merely a feature request (that I may work on a PR for in the future), not meant to be an exhaustive list of cloud vendor SDKs to support.

@dyladan
Copy link
Member

dyladan commented Jan 27, 2021

I believe azure is building opentelemetry support into their cloud sdk but I could be misremembering

@vmarchaud vmarchaud added instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jan 27, 2021
@willarmiros
Copy link
Contributor Author

It appears that Aspecto has already implemented this in their own repo: https://github.com/aspecto-io/opentelemetry-ext-js/tree/master/packages/plugin-aws-sdk

I will open an issue over there to see if they'd be interested in upstreaming their contribution.

@weyert
Copy link

weyert commented Feb 4, 2021

Oh cool, all clear :)

@willarmiros
Copy link
Contributor Author

@vmarchaud
Copy link
Member

It has been upstreamed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants