-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change db.statement
to only be collected if there is sanitization
#1552
Comments
db.statement
to only be collected if there is sanitization in mysql and redisdb.statement
to only be collected if there is sanitization
DynamoDB can be added to the list too. |
Is there anyone working on/driving this? Generally a production blocker unless we can toggle the attribute being applied or, have functionality to scrub/obfuscate (or even having a dedicated, or passing custom, serialiser like: opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-redis/README.md Lines 56 to 75 in de221b0
Noting the DynamoDB extension as an example of the issue: opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/dynamodb.ts Lines 43 to 45 in de221b0
Overriding the |
@ithompson-gp I have addressed DynamoDB in #1748 |
Currently
db.statement
is collected by default and there's no option to disable it. According to open telemetry spec,db.statement
has to be disabled by default.The text was updated successfully, but these errors were encountered: