diff --git a/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactory.java b/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactory.java index 2ae94d45846..92e385992f1 100644 --- a/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactory.java +++ b/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactory.java @@ -48,7 +48,6 @@ public io.opentelemetry.api.common.Attributes create( throw new ConfigurationException( "Error processing attribute with key \"" + key + "\": unexpected null value"); } - Class valueClass = value.getClass(); if (value instanceof String) { builder.put(key, (String) value); return; @@ -73,7 +72,7 @@ public io.opentelemetry.api.common.Attributes create( builder.put(key, (boolean) value); return; } - if (List.class.isAssignableFrom(valueClass)) { + if (value instanceof List) { List values = (List) value; if (values.isEmpty()) { return; diff --git a/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactoryTest.java b/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactoryTest.java index dca78ba641c..bdba5e80bb7 100644 --- a/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactoryTest.java +++ b/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributesFactoryTest.java @@ -76,7 +76,8 @@ void create() { .withAdditionalProperty("intArrKey", Arrays.asList(1, 2)) .withAdditionalProperty("doubleArrKey", Arrays.asList(1.0d, 2.0d)) .withAdditionalProperty("floatArrKey", Arrays.asList(1.0f, 2.0f)) - .withAdditionalProperty("boolArrKey", Arrays.asList(true, false)), + .withAdditionalProperty("boolArrKey", Arrays.asList(true, false)) + .withAdditionalProperty("emptyArrKey", Collections.emptyList()), mock(SpiHelper.class), Collections.emptyList())) .isEqualTo(