Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document metrics on opentelemetry.io #3186

Closed
cartermp opened this issue Sep 18, 2022 · 8 comments · Fixed by open-telemetry/opentelemetry.io#3285
Closed

Document metrics on opentelemetry.io #3186

cartermp opened this issue Sep 18, 2022 · 8 comments · Fixed by open-telemetry/opentelemetry.io#3285
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information enhancement New feature or request
Milestone

Comments

@cartermp
Copy link
Contributor

Hello! This was discussed in the maintainer's meeting. The ask was that we (docs maintainers) come to language SIGs who are ready to start documenting metrics with an outline of what metrics docs should generally look like. We can iterate over time, but the main goal is to ensure that we have getting-started and manual instrumentation docs that cover all the essentials (initialization, creating an instrument, copy-pasteable code samples).

Here's some outlines!

Getting started: open-telemetry/opentelemetry.io#1746 (comment)

Getting started is easiest to define, since Python is already complete. However, if a language (like Go) doesn't already follow this format, it's a bit more work. Mea culpa for me not following up on #2895, which is likely a prerequiste.

Manual instrumentation: open-telemetry/opentelemetry.io#1746 (comment)

The initial take here is just to have each major instrument documented with a code sample. We can probably figure out an ideal way to organize all the metrics content over time.

Note that "✨✨ HELP NEEDED! ✨✨" is present in some places. That's where we need the most help. As a general rule of thumb, it's pretty easy for us to add and update code samples that just use the metric API. However, knowing how to properly initialize things in the most correct way is a challenge. At a minimum, if you can contribute that, then we can probably take it and run with it.

@cartermp cartermp added the enhancement New feature or request label Sep 18, 2022
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Sep 19, 2022
@MrAlias MrAlias added documentation Provides helpful information area:metrics Part of OpenTelemetry Metrics labels Sep 19, 2022
@MrAlias MrAlias moved this from Todo to Blocked in Go: Metric SDK (Beta) Oct 14, 2022
@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 20, 2022
@pellared pellared self-assigned this Jul 25, 2023
@MrAlias MrAlias moved this from Todo to In Progress in Go: Metric SDK (GA) Jul 28, 2023
@pellared pellared moved this from In Progress to Todo in Go: Metric SDK (GA) Aug 3, 2023
@pellared pellared moved this from Todo to In Progress in Go: Metric SDK (GA) Aug 8, 2023
@pellared pellared moved this from In Progress to Todo in Go: Metric SDK (GA) Aug 9, 2023
@pellared pellared removed their assignment Aug 10, 2023
@pellared pellared changed the title [Metrics docs] Proposed structure and placeholders for docs Document metrics on opentelemetry.io Sep 6, 2023
@pellared pellared self-assigned this Sep 6, 2023
@pellared pellared moved this from Todo to In Progress in Go: Metric SDK (GA) Sep 6, 2023
@pellared
Copy link
Member

pellared commented Sep 6, 2023

I had a chat with @svrnm and he suggested to take inspiration/structure/content from: https://opentelemetry.io/docs/instrumentation/js/manual/#metrics

@dmathieu
Copy link
Member

dmathieu commented Sep 6, 2023

And as a starting point/example, we have the otel-collector example about to be updated with metrics: #4466

@cartermp
Copy link
Contributor Author

cartermp commented Sep 6, 2023

I agree with matching what JS has documented.

@cartermp
Copy link
Contributor Author

cartermp commented Sep 6, 2023

Should this issue get transferred to the docs site, or are you all fine with tracking here?

@pellared
Copy link
Member

pellared commented Sep 7, 2023

Should this issue get transferred to the docs site, or are you all fine with tracking here?

@cartermp For us it does not matter where it is as long as it will be in this project.

@MrAlias
Copy link
Contributor

MrAlias commented Sep 14, 2023

@pellared did open-telemetry/opentelemetry.io#3235 resolve this?

@MrAlias
Copy link
Contributor

MrAlias commented Sep 14, 2023

Views still need to be documented.

@pellared
Copy link
Member

@github-project-automation github-project-automation bot moved this from Backlog to Done in Go: Metric SDK (Post-GA) Sep 19, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

5 participants