-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document metrics on opentelemetry.io #3186
Document metrics on opentelemetry.io #3186
Comments
I had a chat with @svrnm and he suggested to take inspiration/structure/content from: https://opentelemetry.io/docs/instrumentation/js/manual/#metrics |
And as a starting point/example, we have the otel-collector example about to be updated with metrics: #4466 |
I agree with matching what JS has documented. |
Should this issue get transferred to the docs site, or are you all fine with tracking here? |
@cartermp For us it does not matter where it is as long as it will be in this project. |
@pellared did open-telemetry/opentelemetry.io#3235 resolve this? |
Views still need to be documented. |
Hello! This was discussed in the maintainer's meeting. The ask was that we (docs maintainers) come to language SIGs who are ready to start documenting metrics with an outline of what metrics docs should generally look like. We can iterate over time, but the main goal is to ensure that we have getting-started and manual instrumentation docs that cover all the essentials (initialization, creating an instrument, copy-pasteable code samples).
Here's some outlines!
Getting started: open-telemetry/opentelemetry.io#1746 (comment)
Getting started is easiest to define, since Python is already complete. However, if a language (like Go) doesn't already follow this format, it's a bit more work. Mea culpa for me not following up on #2895, which is likely a prerequiste.
Manual instrumentation: open-telemetry/opentelemetry.io#1746 (comment)
The initial take here is just to have each major instrument documented with a code sample. We can probably figure out an ideal way to organize all the metrics content over time.
Note that "✨✨ HELP NEEDED! ✨✨" is present in some places. That's where we need the most help. As a general rule of thumb, it's pretty easy for us to add and update code samples that just use the metric API. However, knowing how to properly initialize things in the most correct way is a challenge. At a minimum, if you can contribute that, then we can probably take it and run with it.
The text was updated successfully, but these errors were encountered: