Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PropertyFetcher public and place it in OpenTelemetry.Api #1231

Closed
AlexeiScherbakov opened this issue Sep 4, 2020 · 2 comments · Fixed by #1232
Closed

Make PropertyFetcher public and place it in OpenTelemetry.Api #1231

AlexeiScherbakov opened this issue Sep 4, 2020 · 2 comments · Fixed by #1232
Assignees
Labels
enhancement New feature or request

Comments

@AlexeiScherbakov
Copy link

  1. PropertyFetcher is used as copy-paste in many opentelemetry projects:
  1. It very usefull for other Diagnostics.

I think that it should be public and located in OpenTelemetry.Api assembly. Perhaps it should be placed in the .NET Core framework code?

@AlexeiScherbakov AlexeiScherbakov added the enhancement New feature or request label Sep 4, 2020
@cijothomas
Copy link
Member

We can make it public and move it to https://github.com/open-telemetry/opentelemetry-dotnet/tree/master/src/OpenTelemetry/Instrumentation, and have all instrumentation get it from the common place.

@cijothomas
Copy link
Member

Currently these instrumentations depend on SDK project, instead of the API project, as it has to do some conversion from legacy to new activity, which requires ActivitySourceAdapter, which is in SDK...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants