Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span should provide Record Exception Method #1115

Closed
eddynaka opened this issue Aug 20, 2020 · 0 comments · Fixed by #1116
Closed

Span should provide Record Exception Method #1115

eddynaka opened this issue Aug 20, 2020 · 0 comments · Fixed by #1116
Assignees
Labels
enhancement New feature or request

Comments

@eddynaka
Copy link
Contributor

eddynaka commented Aug 20, 2020

Following the spec, span should provide a Record Exception method.

My suggestion: in the class TelemetrySpan we should provide two methods:

public TelemetrySpan RecordException(Exception ex)
{
    // TODO: actual implementation
}

public TelemetrySpan RecordException(string type, string message, string stacktrace)
{
    // TODO: actual implementation
}

With that, as spec says, add the exception as an Event.

References:

#assign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants