From d294140a337769a815563d872dd3f8365454248b Mon Sep 17 00:00:00 2001 From: Travis Illig Date: Wed, 6 Apr 2022 08:35:38 -0700 Subject: [PATCH] Add VS Code recommended spell check extension (#3127) --- .github/ISSUE_TEMPLATE/question.md | 3 +- .vscode/extensions.json | 3 +- .vscode/settings.json | 48 +++++++++++++++++++ CONTRIBUTING.md | 2 +- docs/metrics/customizing-the-sdk/README.md | 2 +- .../extending-the-sdk/MyEnrichingProcessor.cs | 2 +- src/OpenTelemetry.Api/CHANGELOG.md | 2 +- .../CHANGELOG.md | 4 +- .../CHANGELOG.md | 2 +- .../Implementation/ResourceExtensions.cs | 6 +-- .../ZPagesExporterOptions.cs | 2 +- .../ZPagesProcessor.cs | 2 +- .../CHANGELOG.md | 2 +- .../AspNetTelemetryEventSource.cs | 2 +- .../TelemetryHttpModule.cs | 4 +- .../CHANGELOG.md | 2 +- .../CHANGELOG.md | 2 +- .../Implementation/HttpInListener.cs | 4 +- .../README.md | 2 +- .../CHANGELOG.md | 2 +- src/OpenTelemetry/CHANGELOG.md | 10 ++-- .../JaegerExporterOptionsTests.cs | 4 +- .../OtlpMetricsExporterTests.cs | 12 ++--- .../OtlpTraceExporterTests.cs | 12 ++--- .../ZipkinExporterTests.cs | 2 +- 25 files changed, 93 insertions(+), 45 deletions(-) create mode 100644 .vscode/settings.json diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md index 045837eff1e..fd757f158f0 100644 --- a/.github/ISSUE_TEMPLATE/question.md +++ b/.github/ISSUE_TEMPLATE/question.md @@ -1,10 +1,9 @@ --- name: Question -about: Create a question to help us improve our knowledgebase and documentation +about: Create a question to help us improve our knowledge base and documentation labels: question --- # Question Use [Github Discussions](https://github.com/open-telemetry/opentelemetry-dotnet/discussions/new). - diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 842e35ebec9..67fb4df6231 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -2,6 +2,7 @@ "recommendations": [ "editorconfig.editorconfig", "davidanson.vscode-markdownlint", - "ms-dotnettools.csharp" + "ms-dotnettools.csharp", + "streetsidesoftware.code-spell-checker" ] } diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 00000000000..b267a513f6e --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,48 @@ +{ + "cSpell.words": [ + "asax", + "cijo", + "cncf", + "codebases", + "codecov", + "contoso", + "cref", + "grafana", + "janotti", + "kanzhelev", + "liudmila", + "mikel", + "molkova", + "monocytogenes", + "nakamura", + "netcoreapp", + "netfx", + "netstandard", + "nupkg", + "oneof", + "opentelemetry", + "otel", + "otlp", + "paulo", + "pillai", + "proto", + "protobuf", + "protos", + "reiley", + "rpcz", + "ruleset", + "runtimes", + "sergey", + "struct", + "tbody", + "thead", + "triager", + "umesan", + "unencrypted", + "unvalidated", + "utkarsh", + "xunit", + "zipkin", + "zpages" + ] +} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9db97b2ad6a..ee3bef7e5fd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -211,6 +211,6 @@ This project includes a [`.editorconfig`](./.editorconfig) file which is supported by all the IDEs/editor mentioned above. It works with the IDE/editor only and does not affect the actual build of the project. -This repository also includes stylecop ruleset files under the `./build` folder. +This repository also includes StyleCop ruleset files under the `./build` folder. These files are used to configure the _StyleCop.Analyzers_ which runs during build. Breaking the rules will result in a build failure. diff --git a/docs/metrics/customizing-the-sdk/README.md b/docs/metrics/customizing-the-sdk/README.md index f902cd44f5d..e2b024eeea6 100644 --- a/docs/metrics/customizing-the-sdk/README.md +++ b/docs/metrics/customizing-the-sdk/README.md @@ -295,7 +295,7 @@ allowed to be `1`. This means that the SDK would export measurements from only one `MetricStream`. The very first instrument that is published (`MyFruitCounter` in this case) will create a `MetricStream` and the SDK will thereby reach the maximum `MetricStream` limit of `1`. The measurements from any -susequent instruments added will be dropped. +subsequent instruments added will be dropped. ```csharp using System.Diagnostics.Metrics; diff --git a/docs/trace/extending-the-sdk/MyEnrichingProcessor.cs b/docs/trace/extending-the-sdk/MyEnrichingProcessor.cs index 95612bf3d44..4565852c1b1 100644 --- a/docs/trace/extending-the-sdk/MyEnrichingProcessor.cs +++ b/docs/trace/extending-the-sdk/MyEnrichingProcessor.cs @@ -22,7 +22,7 @@ internal class MyEnrichingProcessor : BaseProcessor public override void OnEnd(Activity activity) { // Enrich activity with additional tags. - activity.SetTag("mycustomTag", "myCustomTagValue"); + activity.SetTag("myCustomTag", "myCustomTagValue"); // Enriching from Baggage. // The below snippet adds every Baggage item. diff --git a/src/OpenTelemetry.Api/CHANGELOG.md b/src/OpenTelemetry.Api/CHANGELOG.md index cba4fee763c..e236143cad0 100644 --- a/src/OpenTelemetry.Api/CHANGELOG.md +++ b/src/OpenTelemetry.Api/CHANGELOG.md @@ -170,7 +170,7 @@ Released 2020-Nov-5 ([#1413](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1413)) * Moving grpc status and helper to grpc project ([#1422](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1422)) -* Renamed TextMapPropagator to TraceContextPropagator, CompositePropapagor to +* Renamed TextMapPropagator to TraceContextPropagator, CompositePropagator to CompositeTextMapPropagator. IPropagator is renamed to TextMapPropagator and changed from interface to abstract class. ([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1427)) diff --git a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md index 23b129c5ef7..aa08052a28b 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md +++ b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md @@ -72,7 +72,7 @@ Released 2021-Sep-13 `BatchExportActivityProcessorOptions` which supports field value overriding using `OTEL_BSP_SCHEDULE_DELAY`, `OTEL_BSP_EXPORT_TIMEOUT`, `OTEL_BSP_MAX_QUEUE_SIZE`, `OTEL_BSP_MAX_EXPORT_BATCH_SIZE` - envionmental variables as defined in the + environmental variables as defined in the [specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.5.0/specification/sdk-environment-variables.md#batch-span-processor). ([#2219](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2219)) @@ -89,7 +89,7 @@ Released 2021-Jul-23 * The `JaegerExporterOptions` defaults can be overridden using `OTEL_EXPORTER_JAEGER_AGENT_HOST` and `OTEL_EXPORTER_JAEGER_AGENT_PORT` - envionmental variables as defined in the + environmental variables as defined in the [specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#jaeger-exporter). ([#2123](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2123)) diff --git a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md index 18c0e3a8984..a65056a969b 100644 --- a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md +++ b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md @@ -219,7 +219,7 @@ Released 2021-Feb-04 Released 2021-Jan-29 -* Changed `OltpTraceExporter` class and constructor from internal to public. +* Changed `OtlpTraceExporter` class and constructor from internal to public. ([#1612](https://github.com/open-telemetry/opentelemetry-dotnet/issues/1612)) * In `OtlpExporterOptions.cs`: Exporter options now include a switch for Batch diff --git a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ResourceExtensions.cs b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ResourceExtensions.cs index 8c6cd63d73e..fd03cb6cf67 100644 --- a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ResourceExtensions.cs +++ b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ResourceExtensions.cs @@ -30,10 +30,10 @@ public static OtlpResource.Resource ToOtlpResource(this Resource resource) foreach (KeyValuePair attribute in resource.Attributes) { - var oltpAttribute = attribute.ToOtlpAttribute(); - if (oltpAttribute != null) + var otlpAttribute = attribute.ToOtlpAttribute(); + if (otlpAttribute != null) { - processResource.Attributes.Add(oltpAttribute); + processResource.Attributes.Add(otlpAttribute); } } diff --git a/src/OpenTelemetry.Exporter.ZPages/ZPagesExporterOptions.cs b/src/OpenTelemetry.Exporter.ZPages/ZPagesExporterOptions.cs index da4445b3219..221382b455d 100644 --- a/src/OpenTelemetry.Exporter.ZPages/ZPagesExporterOptions.cs +++ b/src/OpenTelemetry.Exporter.ZPages/ZPagesExporterOptions.cs @@ -22,7 +22,7 @@ namespace OpenTelemetry.Exporter.ZPages public class ZPagesExporterOptions { /// - /// Gets or sets the port to listen to. Typically it ends with /rpcz like http://localhost:7284/rpcz/. + /// Gets or sets the URL to listen to. Typically it ends with /rpcz like http://localhost:7284/rpcz/. /// public string Url { get; set; } diff --git a/src/OpenTelemetry.Exporter.ZPages/ZPagesProcessor.cs b/src/OpenTelemetry.Exporter.ZPages/ZPagesProcessor.cs index b7062129c96..87d892b364d 100644 --- a/src/OpenTelemetry.Exporter.ZPages/ZPagesProcessor.cs +++ b/src/OpenTelemetry.Exporter.ZPages/ZPagesProcessor.cs @@ -31,7 +31,7 @@ public class ZPagesProcessor : BaseProcessor /// /// Initializes a new instance of the class. /// - /// Zpage Span processor instance. + /// Zpages Span processor instance. public ZPagesProcessor(ZPagesExporter exporter) { this.exporter = exporter; diff --git a/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md b/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md index f996827a120..6767ddc552d 100644 --- a/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md +++ b/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md @@ -61,7 +61,7 @@ Released 2021-Sep-13 `BatchExportActivityProcessorOptions` which supports field value overriding using `OTEL_BSP_SCHEDULE_DELAY`, `OTEL_BSP_EXPORT_TIMEOUT`, `OTEL_BSP_MAX_QUEUE_SIZE`, `OTEL_BSP_MAX_EXPORT_BATCH_SIZE` - envionmental variables as defined in the + environmental variables as defined in the [specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.5.0/specification/sdk-environment-variables.md#batch-span-processor). ([#2219](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2219)) diff --git a/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/AspNetTelemetryEventSource.cs b/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/AspNetTelemetryEventSource.cs index 423b4d29685..3fd4e239d0e 100644 --- a/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/AspNetTelemetryEventSource.cs +++ b/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/AspNetTelemetryEventSource.cs @@ -102,7 +102,7 @@ public void ActivityRestored(string id) } [Event(5, Message = "Failed to invoke OnExecuteRequestStep, Error='{0}'", Level = EventLevel.Error)] - public void OnExecuteRequestStepInvokationError(string error) + public void OnExecuteRequestStepInvocationError(string error) { this.WriteEvent(5, error); } diff --git a/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModule.cs b/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModule.cs index 64117bf6cea..395c5aec12a 100644 --- a/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModule.cs +++ b/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModule.cs @@ -70,7 +70,7 @@ public void Init(HttpApplication context) } catch (Exception e) { - AspNetTelemetryEventSource.Log.OnExecuteRequestStepInvokationError(e.Message); + AspNetTelemetryEventSource.Log.OnExecuteRequestStepInvocationError(e.Message); } } } @@ -108,7 +108,7 @@ private void Application_EndRequest(object sender, EventArgs e) // When the child request completes, the parent request executes the end request notifications and completes itself. // Do not create activity for parent request. Parent request has IIS_UrlRewriteModule ServerVariable with success response code. // Child request contains an additional ServerVariable named - IIS_WasUrlRewritten. - // Track failed response activity: Different modules in the pipleline has ability to end the response. For example, authentication module could set HTTP 401 in OnBeginRequest and end the response. + // Track failed response activity: Different modules in the pipeline has ability to end the response. For example, authentication module could set HTTP 401 in OnBeginRequest and end the response. if (context.Request.ServerVariables != null && context.Request.ServerVariables[URLRewriteRewrittenRequest] == null && context.Request.ServerVariables[URLRewriteModuleVersion] != null && context.Response.StatusCode == 200) { trackActivity = false; diff --git a/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md index 04f248417fa..36437ef80f1 100644 --- a/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md @@ -89,7 +89,7 @@ Released 2020-Nov-17 Released 2020-Nov-5 -* Renamed TextMapPropagator to TraceContextPropagator, CompositePropapagor to +* Renamed TextMapPropagator to TraceContextPropagator, CompositePropagator to CompositeTextMapPropagator. IPropagator is renamed to TextMapPropagator and changed from interface to abstract class. ([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1427)) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md index 9af5516b791..4510ab44e21 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md @@ -95,7 +95,7 @@ Released 2020-Nov-5 [Grpc.AspNetCore](https://www.nuget.org/packages/Grpc.AspNetCore/). This option is enabled by default. ([#1423](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1423)) -* Renamed TextMapPropagator to TraceContextPropagator, CompositePropapagor to +* Renamed TextMapPropagator to TraceContextPropagator, CompositePropagator to CompositeTextMapPropagator. IPropagator is renamed to TextMapPropagator and changed from interface to abstract class. ([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1427)) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs b/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs index 1ac0813cdf1..8e80800d159 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs @@ -263,8 +263,8 @@ public override void OnCustom(string name, Activity activity, object payload) } // TODO: Should we get values from RouteData? - // private readonly PropertyFetcher beforActionRouteDataFetcher = new PropertyFetcher("routeData"); - // var routeData = this.beforActionRouteDataFetcher.Fetch(payload) as RouteData; + // private readonly PropertyFetcher beforeActionRouteDataFetcher = new PropertyFetcher("routeData"); + // var routeData = this.beforeActionRouteDataFetcher.Fetch(payload) as RouteData; } } } diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/README.md b/src/OpenTelemetry.Instrumentation.SqlClient/README.md index 1951c55528f..f6e6c06cadf 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/README.md +++ b/src/OpenTelemetry.Instrumentation.SqlClient/README.md @@ -111,7 +111,7 @@ property should be used to control whether this instrumentation should set the attribute to the text of the `SqlCommand` being executed. This could either be a name of a stored procedure or a full text of a `CommandType.Text` query. -On .NET Framwork, unlike .NET Core, the instrumentation capabilities for both +On .NET Framework, unlike .NET Core, the instrumentation capabilities for both [`Microsoft.Data.SqlClient`](https://www.nuget.org/packages/Microsoft.Data.SqlClient/) and `System.Data.SqlClient` are limited: diff --git a/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md b/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md index b30f875f94a..3db03ea5520 100644 --- a/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md +++ b/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md @@ -53,7 +53,7 @@ Released 2020-Nov-17 Released 2020-Nov-5 -* Renamed TextMapPropagator to TraceContextPropagator, CompositePropapagor +* Renamed TextMapPropagator to TraceContextPropagator, CompositePropagator to CompositeTextMapPropagator. IPropagator is renamed to TextMapPropagator and changed from interface to abstract class. ([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1427)) diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md index d153d8a1ddc..4f48bb8942a 100644 --- a/src/OpenTelemetry/CHANGELOG.md +++ b/src/OpenTelemetry/CHANGELOG.md @@ -22,7 +22,7 @@ Released 2022-Mar-30 ([#3038](https://github.com/open-telemetry/opentelemetry-dotnet/pull/3038)) * Removed `MetricReaderType`. This enumeration was previously used when - configuing a metric reader with an exporter to configure whether the export + configuring a metric reader with an exporter to configure whether the export cycle would be periodic or manual (i.e., requiring a explicit call to flush metrics). This change affects the push-based metric exporters: OTLP, Console, and InMemory. For these exporters, a manual export cycle can now be achieved @@ -165,7 +165,7 @@ Released 2021-Oct-08 * Exception from Observable instrument callbacks does not result in entire metrics being lost. -* SDK is allocation-free on recording of measurements with upto 8 tags. +* SDK is allocation-free on recording of measurements with up to 8 tags. * TracerProviderBuilder.AddLegacySource now supports wildcard activity names. ([#2183](https://github.com/open-telemetry/opentelemetry-dotnet/issues/2183)) @@ -196,7 +196,7 @@ Released 2021-Sep-13 * Add `BatchExportActivityProcessorOptions` which supports field value overriding using `OTEL_BSP_SCHEDULE_DELAY`, `OTEL_BSP_EXPORT_TIMEOUT`, - `OTEL_BSP_MAX_QUEUE_SIZE`, `OTEL_BSP_MAX_EXPORT_BATCH_SIZE` envionmental + `OTEL_BSP_MAX_QUEUE_SIZE`, `OTEL_BSP_MAX_EXPORT_BATCH_SIZE` environmental variables as defined in the [specification](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.5.0/specification/sdk-environment-variables.md#batch-span-processor). ([#2219](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2219)) @@ -364,7 +364,7 @@ Released 2021-Jan-29 for Activity.Recorded in SimpleActivityExportProcessor and BatchActivityExportProcessor ([#1622](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1622)) -* Added check in `ActivitySourceAdapter` class for root activity if traceid is +* Added check in `ActivitySourceAdapter` class for root activity if trace ID is overridden by calling `SetParentId` ([#1355](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1355)) * Resource Attributes now accept int, short, and float as values, converting @@ -378,7 +378,7 @@ Released 2021-Jan-29 * `BatchExportProcessor` will now flush any remaining spans left in a `Batch` after the export operation has completed. ([#1726](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1726)) -* Fixed a bug to allow the Self Diagnostics log file to be opened simutaneously +* Fixed a bug to allow the Self Diagnostics log file to be opened simultaneously by another process in read-only mode for .NET Framework. ([#1693](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1693)) * Metrics removed as it is not part 1.0.0 release. See issue diff --git a/test/OpenTelemetry.Exporter.Jaeger.Tests/JaegerExporterOptionsTests.cs b/test/OpenTelemetry.Exporter.Jaeger.Tests/JaegerExporterOptionsTests.cs index c35a90edf68..33143faf16f 100644 --- a/test/OpenTelemetry.Exporter.Jaeger.Tests/JaegerExporterOptionsTests.cs +++ b/test/OpenTelemetry.Exporter.Jaeger.Tests/JaegerExporterOptionsTests.cs @@ -48,14 +48,14 @@ public void JaegerExporterOptions_Defaults() [Fact] public void JaegerExporterOptions_EnvironmentVariableOverride() { - Environment.SetEnvironmentVariable(JaegerExporterOptions.OTelAgentHostEnvVarKey, "jeager-host"); + Environment.SetEnvironmentVariable(JaegerExporterOptions.OTelAgentHostEnvVarKey, "jaeger-host"); Environment.SetEnvironmentVariable(JaegerExporterOptions.OTelAgentPortEnvVarKey, "123"); Environment.SetEnvironmentVariable(JaegerExporterOptions.OTelProtocolEnvVarKey, "http/thrift.binary"); Environment.SetEnvironmentVariable(JaegerExporterOptions.OTelEndpointEnvVarKey, "http://custom-endpoint:12345"); var options = new JaegerExporterOptions(); - Assert.Equal("jeager-host", options.AgentHost); + Assert.Equal("jaeger-host", options.AgentHost); Assert.Equal(123, options.AgentPort); Assert.Equal(JaegerExportProtocol.HttpBinaryThrift, options.Protocol); Assert.Equal(new Uri("http://custom-endpoint:12345"), options.Endpoint); diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs index c3902d0cd50..95a4288a33f 100644 --- a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs +++ b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs @@ -166,16 +166,16 @@ public void ToOtlpResourceMetricsTest(bool includeServiceNameInResource) Assert.Single(request.ResourceMetrics); var resourceMetric = request.ResourceMetrics.First(); - var oltpResource = resourceMetric.Resource; + var otlpResource = resourceMetric.Resource; if (includeServiceNameInResource) { - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.StringValue == "service-name"); - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceNamespace && kvp.Value.StringValue == "ns1"); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.StringValue == "service-name"); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceNamespace && kvp.Value.StringValue == "ns1"); } else { - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.ToString().Contains("unknown_service:")); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.ToString().Contains("unknown_service:")); } Assert.Single(resourceMetric.InstrumentationLibraryMetrics); @@ -265,7 +265,7 @@ public void TestGaugeToOtlpMetric(string name, string description, string unit, [InlineData("test_counter", null, null, 123, null, AggregationTemporality.Delta, true)] [InlineData("test_counter", "description", "unit", 123, null, AggregationTemporality.Cumulative, true)] [InlineData("test_counter", null, null, 123, null, AggregationTemporality.Delta, true, "key1", "value1", "key2", 123)] - public void TestCounterToOltpMetric(string name, string description, string unit, long? longValue, double? doubleValue, AggregationTemporality aggregationTemporality, bool isMonotonic, params object[] keysValues) + public void TestCounterToOtlpMetric(string name, string description, string unit, long? longValue, double? doubleValue, AggregationTemporality aggregationTemporality, bool isMonotonic, params object[] keysValues) { var metrics = new List(); @@ -361,7 +361,7 @@ public void TestCounterToOltpMetric(string name, string description, string unit [InlineData("test_histogram", null, null, 123, null, AggregationTemporality.Delta)] [InlineData("test_histogram", "description", "unit", 123, null, AggregationTemporality.Cumulative)] [InlineData("test_histogram", null, null, 123, null, AggregationTemporality.Delta, "key1", "value1", "key2", 123)] - public void TestHistogramToOltpMetric(string name, string description, string unit, long? longValue, double? doubleValue, AggregationTemporality aggregationTemporality, params object[] keysValues) + public void TestHistogramToOtlpMetric(string name, string description, string unit, long? longValue, double? doubleValue, AggregationTemporality aggregationTemporality, params object[] keysValues) { var metrics = new List(); diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs index b90aa5cdf02..2b122bd7793 100644 --- a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs +++ b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs @@ -179,15 +179,15 @@ void RunTest(Batch batch) request.AddBatch(resourceBuilder.Build().ToOtlpResource(), batch); Assert.Single(request.ResourceSpans); - var oltpResource = request.ResourceSpans.First().Resource; + var otlpResource = request.ResourceSpans.First().Resource; if (includeServiceNameInResource) { - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.StringValue == "service-name"); - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceNamespace && kvp.Value.StringValue == "ns1"); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.StringValue == "service-name"); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceNamespace && kvp.Value.StringValue == "ns1"); } else { - Assert.Contains(oltpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.ToString().Contains("unknown_service:")); + Assert.Contains(otlpResource.Attributes, (kvp) => kvp.Key == ResourceSemanticConventions.AttributeServiceName && kvp.Value.ToString().Contains("unknown_service:")); } foreach (var instrumentationLibrarySpans in request.ResourceSpans.First().InstrumentationLibrarySpans) @@ -349,8 +349,8 @@ public void ToOtlpSpanActivitiesWithNullArrayTest() } [Theory] - [InlineData(ActivityStatusCode.Unset, "Description will be ingored if status is Unset.")] - [InlineData(ActivityStatusCode.Ok, "Description will be ingored if status is Okay.")] + [InlineData(ActivityStatusCode.Unset, "Description will be ignored if status is Unset.")] + [InlineData(ActivityStatusCode.Ok, "Description will be ignored if status is Okay.")] [InlineData(ActivityStatusCode.Error, "Description will be kept if status is Error.")] public void ToOtlpSpanNativeActivityStatusTest(ActivityStatusCode expectedStatusCode, string statusDescription) { diff --git a/test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs b/test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs index 02b32b2ab52..2e34b9d465e 100644 --- a/test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs +++ b/test/OpenTelemetry.Exporter.Zipkin.Tests/ZipkinExporterTests.cs @@ -92,7 +92,7 @@ public void BadArgs() } [Fact] - public void SuppresssesInstrumentation() + public void SuppressesInstrumentation() { const string ActivitySourceName = "zipkin.test"; Guid requestId = Guid.NewGuid();