Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Coding guidelines regarding context and TelemetrySettings #9159

Open
mx-psi opened this issue Dec 20, 2023 · 0 comments
Open

Update Coding guidelines regarding context and TelemetrySettings #9159

mx-psi opened this issue Dec 20, 2023 · 0 comments

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 20, 2023 •
edited
Loading

The coding guidelines should reflect that

  1. Methods and functions that make use or could make use of filesystem or networking capabilities, as well as interfaces that may have implementations that use them should have context.Context passed to them.
  2. Methods and functions that we may need to be instrumented should have a component.TelemetrySettings passed to them.

Originally reported on #7954 (comment) and discussed on #9105
@mx-psi mx-psi mentioned this issue Dec 20, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mx-psi