Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPServerSettings: Support for additional headers #7328

Closed
ledor473 opened this issue Mar 7, 2023 · 6 comments
Closed

HTTPServerSettings: Support for additional headers #7328

ledor473 opened this issue Mar 7, 2023 · 6 comments

Comments

@ledor473
Copy link
Contributor

ledor473 commented Mar 7, 2023

Is your feature request related to a problem? Please describe.
When deploying an OpenTelemetry Collector with httpforwarder or healthcheckextension behind a caching proxy or a CDN, the GET requests gets cached and there's currently no options to pass additional headers on HTTPServerSettings.

Here are some links for various caching proxy that documents the headers that can be used to configure the cache behavior:

Describe the solution you'd like
Add a headers configuration to HTTPServerSettings.

It would be similar to the headers property on HTTPClientSettings:

// Additional headers attached to each HTTP request sent by the client.
// Existing header values are overwritten if collision happens.
// Header values are opaque since they may be sensitive.
Headers map[string]configopaque.String `mapstructure:"headers"`

Describe alternatives you've considered
I've looked at CORSSettings that is exposed but it only exposes MaxAge that ends up in Access-Control-Max-Age

@atoulme
Copy link
Contributor

atoulme commented Apr 13, 2023

@ledor473 would you like to work on this issue? I'd be happy to assign it to you.

@ledor473
Copy link
Contributor Author

If the proposal makes sense, I'd be happy to contribute it yes.

@atoulme
Copy link
Contributor

atoulme commented Apr 17, 2023

not sure, you can bring it to the SIG meeting for discussion or open a PR to provoke thoughts.

@atoulme
Copy link
Contributor

atoulme commented Jul 13, 2023

@ledor473 ready to close? This was shipped in 0.81.0.

@ledor473
Copy link
Contributor Author

Yep! I thought it would auto-close. Closing..

@atoulme
Copy link
Contributor

atoulme commented Jul 13, 2023

It closes only if in the PR you use the keyword Fixes, as in Fixes #foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants