From 48af1b8ea63a3393e468368beed47ce3668e5c73 Mon Sep 17 00:00:00 2001 From: Curtis Robert Date: Fri, 14 Jun 2024 13:46:46 -0700 Subject: [PATCH] [chore][golangci-lint] Remove gosec excludes (#10411) #### Description The upstream issue was fixed by https://github.com/golangci/golangci-lint/pull/4748, which was included in release [`v1.59.0`](https://github.com/golangci/golangci-lint/releases/tag/v1.59.0) of `golangci-lint`. From local testing, we're pulling version `v1.59.0` of `golangci-lint`, so the issue should be resolved. Local runtime with excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 1.866075148s INFO Execution took 1.218805785s INFO Execution took 1.09527985s ``` Local runtime without excludes: ``` $ .tools/golangci-lint run -v --enable-only gosec ... INFO Execution took 2.244716429s INFO Execution took 1.539717296s INFO Execution took 1.530163777s ``` Note: I ran `.tools/golangci-lint cache clean` between each test to clean the cache and keep results as consistent as possible. #### Link to tracking issue Fixes https://github.com/open-telemetry/opentelemetry-collector/issues/10213 --- .golangci.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 103ebae9c18..b106c5d8f23 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -119,13 +119,6 @@ linters-settings: files: - "!**/*_test.go" - gosec: - excludes: - # https://github.com/open-telemetry/opentelemetry-collector/issues/10213 - - G601 - # https://github.com/open-telemetry/opentelemetry-collector/issues/10213 - - G113 - linters: enable: - depguard