From 0cb309c9b277d44384df1f4e7eaa24f4e72313ac Mon Sep 17 00:00:00 2001 From: Antonio Jimenez <antonjim@cisco.com> Date: Mon, 11 Sep 2023 13:55:11 +0200 Subject: [PATCH] review PR --- .chloggen/SampledLoggerTelemetry.yaml | 2 +- service/telemetry/telemetry.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.chloggen/SampledLoggerTelemetry.yaml b/.chloggen/SampledLoggerTelemetry.yaml index 34eaf0413eb..a4589189555 100644 --- a/.chloggen/SampledLoggerTelemetry.yaml +++ b/.chloggen/SampledLoggerTelemetry.yaml @@ -15,7 +15,7 @@ issues: [8134] # (Optional) One or more lines of additional information to render under the primary note. # These lines will be padded with 2 spaces and then inserted directly into the document. # Use pipe (|) for multiline entries. -subtext: The sampled logger is built from the logger. It is built using default config (sample 100 logs in a second after 10 initial logs) +subtext: The sampled logger is built from the logger. It is configured sampling 100 logs in a second after 10 initial logs) # Optional: The change log or logs in which this entry should be included. diff --git a/service/telemetry/telemetry.go b/service/telemetry/telemetry.go index 4c411c90aa4..410e2c1d267 100644 --- a/service/telemetry/telemetry.go +++ b/service/telemetry/telemetry.go @@ -58,7 +58,6 @@ func New(_ context.Context, set Settings, cfg Config) (*Telemetry, error) { if err != nil { return nil, err } - tp := sdktrace.NewTracerProvider( // needed for supporting the zpages extension sdktrace.WithSampler(alwaysRecord()),