-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure prometheus receiver garbage collection interval #4756
Comments
@dashpole For visibility |
open-telemetry/opentelemetry-collector#3047 might have changed this behavior recently. |
With open-telemetry/opentelemetry-collector#3047, the first timeseries will not be dropped. The remaining issue is for metrics scraped every 2+ minutes, the starttime is always adjusted even if the process is not restarted. |
Should the garbage collection interval be based on the scrape interval? |
If we decide to do anything here, we shouldn't do it in the Prometheus receiver. @tigrannajaryan @mxiamxia Maybe this is another case for merging the ballast extension + memory limiter. Then, we can add gc tuning options. It seems like we need a global memory management component. |
I think this is referring to the GC implemented inside the prometheus receiver for the data used to determine start times.
The scrape interval can be set per-job, right? There is only one GC interval that cleans the JobMap for all jobs. Maybe it could be set to the max scrape interval. |
Yeah, thats what I had in mind. |
@Aneurysm9 My bad, thanks for the clarification. |
Is your feature request related to a problem? Please describe.
For prometheus receivers which disable UseStartTimeMetric to scrape endpoints sampling metrics every 2+ minutes, the timeseries are always reset as the initial, and no metrics will be passed to nextConsumer.
Describe the solution you'd like
Provide an option in prometheus receiver to configure the gc interval
The text was updated successfully, but these errors were encountered: