-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout config key collision #37332
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Do you actually need different timeouts for the whole operation and for each request? Or do you actually just want a timeout for each request (and the overall timeout is preventing retries)? |
I need each request to be retried individually in case it times out; but the overall operation timeout prevents it. Each call to |
Component(s)
exporter/prometheusremotewrite
What happened?
Description
There is a collision of config keys here:
Steps to Reproduce
Try to configure both
Config.Timout
andConfig.ClientConfig.Timeout
.Expected Result
The timeouts are different.
Actual Result
The timeouts are equal and have the value given by
"timeout"
key in config file.Collector version
v0.117.0,v0.111.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
Log output
Additional context
The text was updated successfully, but these errors were encountered: