Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud account ID detection in EKS environment #37179

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

tilakchowdary
Copy link
Contributor

@tilakchowdary tilakchowdary commented Jan 13, 2025

Description

This enhancement detects AWS EKS cloud account ID.
Account ID is obtained by querying the EC2 Metadata service for the Instance Identity Document and extracting the AccountID field from this document

Testing

Manual testing in EKS cluster with EC2 instances. Unit tests for basic functionality

Documentation

Updated metadata

@tilakchowdary tilakchowdary requested review from dashpole and a team as code owners January 13, 2025 21:55
Copy link

linux-foundation-easycla bot commented Jan 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Jan 13, 2025
@github-actions github-actions bot requested a review from Aneurysm9 January 13, 2025 21:56
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise LGTM

@dmitryax dmitryax merged commit 52d1876 into open-telemetry:main Jan 15, 2025
163 of 164 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 15, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2025
#### Description

This enhancement detects AWS EKS cloud account ID. 
Account ID is obtained by querying the EC2 Metadata service for the
Instance Identity Document and extracting the AccountID field from this
document

#### Testing
Manual testing in EKS cluster with EC2 instances. Unit tests for basic
functionality

#### Documentation
Updated metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants