-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/azureeventhub] Use attributes/fields to represent Azure logs #16283
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I think it makes sense that the receiver would be able to parse the logs into the OTel data model. @loomis-relativity, any thoughts on how the configuration would need to change in order to support either mode? |
Great feedback, thanks! The kafka receiver uses the notion of codecs to allow setting up different behaviors, look at the |
This makes sense to me. Which behavior should be the default? (I tend to think it should be whichever requires less user configuration in order to be useful.) |
I think once the |
@djaglowski @atoulme I think having a simple switch for the behavior is fine. Once the log has been translated to OpenTelemetry format, users can use processors to do further transformations if they need it; no need to add switches for that here. |
@loomis-relativity so to be super clear: your contribution is most welcome. That's a great development :D |
@atoulme We'll have to get it pulled into a sprint, but there's no problem in principle for us to do the work. Legal has already approved contributions to OpenTelemetry, so there shouldn't be further delays once we've got something. Don't wait on us though, if you want to tackle it. |
There's several things to do, so let's just make a list here and whoever can take this can take some of it rather than the brunt of the work:
|
@atoulme @djaglowski Below is a proposed mapping between the Azure resource logs schema and OpenTelemetry. Comments?
|
At a glance, it makes sense to me. But I'm not the right person to review this. I recommend that you look at the existing mappings here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#splunk-hec and open a PR under the specification repository with this table for review. |
@atoulme @djaglowski See the PR (#16357) for an initial implementation. I'll pull this into our custom collector to test it. Unfortunately, that will happen after the Thanksgiving break. In the meantime, any feedback on the PR is welcome. You should be able to modify the PR if necessary. |
Component(s)
receiver/azureeventhub
Is your feature request related to a problem? Please describe.
The current implementation dumps the entire Azure log into the body of the OpenTelemetry log record as a byte array. This causes the log to be complete opaque and unusable in our storage backends (one of which happens to be New Relic).
Describe the solution you'd like
Given that the Azure log records are already structured and follow a standard format, we prefer that the Azure log was parsed and then injected into the OpenTelemetry log record as attributes.
Describe alternatives you've considered
None.
Additional context
If this is acceptable, we'd be willing to contribute to the implementation.
The text was updated successfully, but these errors were encountered: