Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receivers/prometheusreceiver] ensure that TA scrapeconfigs are merged with statically defined ones #12938

Closed
secustor opened this issue Aug 3, 2022 · 6 comments
Labels
closed as inactive priority:needed Triagers reviewed the issue but need code owner to set priority receiver/prometheus Prometheus receiver Stale

Comments

@secustor
Copy link
Member

secustor commented Aug 3, 2022

Is your feature request related to a problem? Please describe.
The imported code of Prometheus does not work with scrape configs which happen to conflicting each other.
There there has to be a mechanism to prevent this.

Describe the solution you'd like

Describe alternatives you've considered
An alternative would be to simply not allow mixed operation of static configs and job retrieval from a target allocator.

Additional context
#12586 (comment)

@TylerHelmuth TylerHelmuth added receiver/prometheus Prometheus receiver priority:needed Triagers reviewed the issue but need code owner to set priority labels Aug 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Pinging code owners: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

@secustor do you have a chance to work on this issue?

@secustor
Copy link
Member Author

secustor commented Aug 12, 2022

I have some other tasks to do first, so not immediately.

@dmitryax
Copy link
Member

Sure, just wanted to see if this can be assigned to you

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive priority:needed Triagers reviewed the issue but need code owner to set priority receiver/prometheus Prometheus receiver Stale
Projects
None yet
Development

No branches or pull requests

3 participants