-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The build was hard code to amd64 for docker build #11873
Comments
I think the docker make target is intended specifically to build a collector to run inside a container, |
Thanks @codeboten , but still have a question: why hardcoding docker build to amd64? With docker build, it should also support multi-arch as well. |
It's a good question, based on git blame it looks like the decision was made over 2 years ago. I'm not sure why |
@gyliu513 Are you free to update the docker-otelcontribcol target to support more architectures? |
@TylerHelmuth Yes, glad to help. Will fix early next week. |
#12217 doesn't seem like introduced multi arch image creation |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Describe the bug
A clear and concise description of what the bug is.
After I run
make docker-otelcontribcol
on my mac, I found the binary name wasotelcontribcol_linux_amd64
, seems the makefile is hardcoding the GOARCH as amd64 https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/Makefile#L241 , any reason why? Thanks!Steps to reproduce
If possible, provide a recipe for reproducing the error.
What did you expect to see?
A clear and concise description of what you expected to see.
What did you see instead?
A clear and concise description of what you saw instead.
What version did you use?
Version: (e.g.,
v0.4.0
,1eb551b
, etc)What config did you use?
Config: (e.g. the yaml config file)
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: