Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics 4 migration followup #5384

Closed
4 of 5 tasks
chalin opened this issue Nov 14, 2022 · 7 comments · Fixed by #5683
Closed
4 of 5 tasks

Google Analytics 4 migration followup #5384

chalin opened this issue Nov 14, 2022 · 7 comments · Fixed by #5683
Labels

Comments

@chalin
Copy link
Contributor

chalin commented Nov 14, 2022

This is a followup to:

Cleanup tasks:

/cc @caniszczyk @nate-double-u @srenatus

@srenatus
Copy link
Contributor

⚠️ Our feedback thing isn't based on docsy: https://github.com/open-policy-agent/opa/blob/main/docs/website/layouts/partials/feedback.html

@srenatus
Copy link
Contributor

Also, if the GA snippet is now injected via Netlify, we should remove the hugo code for it: https://github.com/open-policy-agent/opa/blob/main/docs/website/layouts/partials/google-analytics.html and it's usage in https://github.com/open-policy-agent/opa/blob/main/docs/website/layouts/_default/baseof.html#L11

@chalin
Copy link
Contributor Author

chalin commented Nov 14, 2022

Thanks for the clarifications @srenatus.

@srenatus
Copy link
Contributor

@chalin Thanks for pushing this forward! One thing that isn't clear to me is whether you're still working on this, or if you've recorded these follow-ups for someone else to pick up. 🤔

@chalin
Copy link
Contributor Author

chalin commented Nov 16, 2022

@srenatus - I'm currently prioritizing the migration of other projects so that their GA4 site tags can start receiving data. I don't know if I'll be working on follow up tasks or not -- if I do, it probably wont be before 23Q3. So feel free to work on this PR when you feel the time is right :).

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@stale stale bot added the inactive label Dec 16, 2022
@chalin
Copy link
Contributor Author

chalin commented Feb 20, 2023

Hi. This is still relevant. Also see, #5382 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants