Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider object on DELETE nullability #2515

Closed
acpana opened this issue Jan 12, 2023 · 1 comment
Closed

reconsider object on DELETE nullability #2515

acpana opened this issue Jan 12, 2023 · 1 comment

Comments

@acpana
Copy link
Contributor

acpana commented Jan 12, 2023

Do we want to emulate real admission requests for the DELETE operation such that object is the new object being admitted. It is null for DELETE operations.

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-request-and-response

Originally posted by @ritazh in #2512 (comment)

@acpana
Copy link
Contributor Author

acpana commented Feb 1, 2023

Adding some context per an offline chat w @maxsmythe about this. Doing so (object == nil on DELETE) may break constraints that rely on the previous behavior in gatekeeper.

@acpana acpana closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant