v5.0: Change MCA component build style default to static #8704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opal_mca.m4 was setting enable_dlopen after it was processed, and the dlopen argument checking was overriding configure arguments that belong to opal_mca. Clean up the late change in enable_dlopen and handle the --disable-dlopen case in opal_mca instead of overriding user options. Signed-off-by: Brian Barrett <[email protected]> (cherry picked from commit ca72bd4)
Remove an environment variable that probably did something at one point, but is dead code now. Git history is hard to follow due to some reverts in the SVN days. Signed-off-by: Brian Barrett <[email protected]> (cherry picked from commit 76328f0)
Default to building MCA components into the library, rather than as dso objects, since most users are not taking advantage of per-library packaging, and this results in less stat/open/etc. calls during application startup. Clean up the static/dso selection logic for componets at the same time. Before, it was relatively hard to describe what would happen if there was a mix of --enable-mca-dso and --enable-mca-static arguments. Now, the code will first look for a component-specific argument, then a framework-level argument, then a global argument. If there is a tie, static is preferred. Update the NEWS and README.md to document the changes. Jeff Squyres wrote the original update to the README file, which was adopted to the new README.md format. Signed-off-by: Brian Barrett <[email protected]> (cherry picked from commit 930260c)
jsquyres
approved these changes
Mar 25, 2021
jsquyres
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series primarily changes the default component build style from dso to static. At the same time, it cleans up some minor nits and clarifies the selection logic when there are conflicting --enable-mca-dso and --enable-mca-static arguments.
Backport of #8132.