master: Bull 2020 update of coll/han #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes and fixes current code for coll/Han: - a barrier is added - a "simple" scatter is added - some Doxygen documentation is added Fix: - compilation and cppcheck warnings - corner case errors when parsing a rule file Signed-off-by: Emmanuel Brelle <[email protected]>
|
Can one of the admins verify this patch? |
EmmanuelBRELLE
changed the title
|
ok to test |
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/039abe769567af0561aabf4505a4ac4c |
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/67857e77c32482be7217d179f6dcdd7f |
|
IBM Ci had an issue over the weekend. Retrying. bot:ibm:retest |
bosilca
approved these changes
Feb 8, 2021
|
Is there anything I can do to help the review ? Otherwise, could this PR be merged ? |
|
since @bosilca already approved this PR, I am merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes and fixes current code for coll/Han:
Fix:
Signed-off-by: Emmanuel Brelle [email protected]