Minor cleanup in the monitoring PML. #7284
Conversation
| @@ -253,7 +253,7 @@ void mca_common_monitoring_finalize( void ) | |||
| } | |||
| } | |||
|
|
|||
| void mca_common_monitoring_register(void*pml_monitoring_component) | |||
| int mca_pml_monitoring_register(void) | |||
There was a problem hiding this comment.
Seems strange to define a mca_pml_monitoring_register() function in the common_monitoring.c, but the common files are kinda a wild west, so go for it.
There was a problem hiding this comment.
I could indeed change the name to reflect the real meaning of this function. One problem remains however, all these MCA parameters are tied to the monitoring PML, as the PML is required for the entire monitoring infrastructure to work.
There was a problem hiding this comment.
Really funny thing we got here. I tried to fix this, and move the MCA variables out of the PML scope into the common/monitoring scope. Well, that didn't work well, the common scope is removed last, after the last usage of any user of the common support, which means a moment where the common shared libraries are already dlclosed. And this, generate segfaults on all string registrations.
Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
fix/monitoring_registration
branch
from
8d4696b to
05093f9
Compare
Signed-off-by: George Bosilca [email protected]