v4.0.x: Allow user to overwrite OMPI_ENABLE_MPI1_COMPAT
#6469
Conversation
Follow-up to open-mpi#6120. As mentioned in [1], it may be desirable to nevertheless get the hidden MPI 1 prototypes, for users who know what they are doing, i.e., the tools guys. @ggouaillardet mentioned in [2], that `-DOMPI_OMIT_MPI1_COMPAT_DECLS=0` should work, but it does not, as than we only get redefinition warnings. See [3]. This topic does not relate to master, as we can remove the actual symbols there, but here in v4.0.x land, the symbols are always there. [1] open-mpi#6120 (comment) [2] open-mpi#6120 (comment) [3] open-mpi#6120 (comment) Signed-off-by: Bert Wesarg <[email protected]>
|
Please note, that I'm not allowed to set any reviewers and labels. |
|
@gpaulsen can you please review this ? Since these symbols were removed from |
|
Yes, this looks good. |
Because its to late for configure, tools work on an installed package. |
|
The FAQ should be updated. And possibly the README...? |
bertwesarg
deleted the
v4.0.x-allow-user-to-overwrite-OMPI_ENABLE_MPI1_COMPAT
branch
Follow-up to #6120.
As mentioned in [1], it may be desirable to nevertheless get the hidden
MPI 1 prototypes, for users who know what they are doing, i.e., the tools
guys. @ggouaillardet mentioned in [2], that
-DOMPI_OMIT_MPI1_COMPAT_DECLS=0should work, but it does not, as than we only get redefinition warnings.
See [3].
This topic does not relate to master, as we can remove the actual symbols
there, but here in v4.0.x land, the symbols are always there.
[1] #6120 (comment)
[2] #6120 (comment)
[3] #6120 (comment)
Signed-off-by: Bert Wesarg [email protected]