Correctly propagate the oversubscribe flag to the spawnees #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aurélien Bouteiller <[email protected]>
rhc54
approved these changes
Oct 24, 2018
bosilca
approved these changes
Oct 24, 2018
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for the 'oversubscribe' flag to be propagated to spawnees in an MPI_COMM_SPAWN and friends, the 'SUBSCRIBE_GIVEN' flag must also be set.
The discussion in #5376 states that by default OVERSUBSCRIBE would not be propagated to spawns. It however appears that the existing code is not conditional on the inherit mca parameter, hence, by making the feature work, this patch will also make it inherited 'by default'. This is unlike what was discussed in the issue. I believe that, unlike the slot assignments etc, it is useful to inherit
-oversubscribeby default (same goes for-nolocalIMO), but can be debated.Signed-off-by: Aurélien Bouteiller [email protected]