v3.0.x: osc/pt2pt: disable when THREAD_MULTIPLE. #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion at open-mpi#2614 (comment), do not allow for selection of the OSC PT2PT when creating an MPI RMA window when THREAD_MULTIPLE is active. Print a helpful message and return a not-supported error. Signed-off-by: Howard Pritchard <[email protected]> Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit d0ffd66) Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 5b7c866)
hjelmn
approved these changes
May 29, 2018
|
bot:retest Mellanox is having trouble merging. Let's give it one more try... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion at
#2614 (comment),
do not allow for selection of the OSC PT2PT when creating an MPI RMA
window when THREAD_MULTIPLE is active. Print a helpful message and
return a not-supported error.
Signed-off-by: Howard Pritchard [email protected]
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit d0ffd66)
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit 5b7c866)
Per #2614 (comment), we decided to disable osc/pt2pt on v3.0.x when THREAD_MULTIPLE. Problem will be solved a different way (see that comment for more details).