Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtl: remove MXM MTL #5180

Merged
merged 1 commit into from
May 23, 2018
Merged

mtl: remove MXM MTL #5180

merged 1 commit into from
May 23, 2018

Conversation

bwbarrett
Copy link
Member

Remove the MXM MTL, which has been deprecated in preference for
the Yalla PML. This was discussed at the last developers meeting
and somehow I ended up with the action item to do the removal.

Signed-off-by: Brian Barrett [email protected]

@bwbarrett
mtl: remove MXM MTL
09e4c40 
Remove the MXM MTL, which has been deprecated in preference for
the Yalla PML.  This was discussed at the last developers meeting
and somehow I ended up with the action item to do the removal.

Signed-off-by: Brian Barrett <[email protected]>
@bwbarrett bwbarrett requested a review from jladd-mlnx May 21, 2018 21:19
@bwbarrett bwbarrett added this to the v4.0.0 milestone May 21, 2018
@bwbarrett
Copy link
Member Author

@jladd-mlnx there was some confusion in the release manager call today about whether Mellanox wanted to remove just the MXM MTL or all the MXM support.

@jladd-mlnx
Copy link
Member

@bwbarrett Just the MTL. We need to keep Yalla around until we completely deprecate and remove MXM from HPC-X.

jladd-mlnx
jladd-mlnx approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@jladd-mlnx jladd-mlnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsquyres
Copy link
Member

@jladd-mlnx @artpol84 The Mellanox CI is running some tests with -mca pml cm -mca mtl mxm, which will obviously fail (on master and future branches) once this PR is merged.

Can it be updated to skip those tests when the MXM MTL is not present?

@jsquyres
Copy link
Member

@jladd-mlnx The following text about MXM is in the top-level README -- do you want to amend it by saying something about how Mellanox is favoring UCX these days / yadda yadda yadda?

- MXM is the Mellanox Messaging Accelerator library utilizing a full
  range of IB transports to provide the following messaging services
  to the upper level MPI/OpenSHMEM libraries:

  - Usage of all available IB transports
  - Native RDMA support
  - Progress thread
  - Shared memory communication
  - Hardware-assisted reliability

I also note that there's oshmem/mca/atomic/mxm and oshmem/mca/spml/ikrit. Per your above note, should both of those be kept until MXM is removed from HPC-X? Speaking of which, is there a public timeline for when MXM will be removed from HPC-X?

Thanks!

@artpol84
Copy link
Contributor

@karasevb, please resolve Jenkins failures.

@jladd-mlnx
Copy link
Member

No public date yet. Ideally, it would happen for our end of October release this year.

karasevb pushed a commit to karasevb/jenkins_scripts that referenced this pull request May 23, 2018
ompi: disables mtl mxm
bc368ce 
Refs open-mpi/ompi#5180
@karasevb karasevb mentioned this pull request May 23, 2018
Merged
@artpol84
Copy link
Contributor

bot:mellanox:retest

@jladd-mlnx jladd-mlnx merged commit 8231706 into open-mpi:master May 23, 2018
@hppritcha hppritcha mentioned this pull request Aug 22, 2018
Closed
@bwbarrett bwbarrett deleted the feature/remove-mxm branch May 8, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jladd-mlnx jladd-mlnx jladd-mlnx approved these changes

Assignees
No one assigned
Labels
Target: main
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bwbarrett @jladd-mlnx @jsquyres @artpol84