sharedfp/sm: close the named semaphore #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
based on the log, I do not think that the Mellanox failure has anything to do with this patch. It seems to be running in a timeout issue in a completely unrelated test. |
|
bot:mellanox:retest |
|
@edgargabriel yes, we are working to solve this. |
|
@edgargabriel can you please add a reference to the cherry-pick'ed commit 4d995bd ? |
in case a named semaphore is used, it is necessary to close the semaphore to remove all sm segments. sem_unlink just removes the name references once all proceeses have closed the sem. This is a cherry-pick of commit 4d995bd Fixes issue: open-mpi#4336 Signed-off-by: Edgar Gabriel <[email protected]> sharedfp/sm: unlink only needs to be called by one process Signed-off-by: Edgar Gabriel <[email protected]>
edgargabriel
force-pushed
the
pr/v2.x-sem-close-fix
branch
from
9144211 to
444e95b
Compare
|
done, thanks for the reminder, forgot about it. |
ggouaillardet
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case a named semaphore is used, it is necessary to close the semaphore to remove
all sm segments. sem_unlink just removes the name references once all proceeses have closed
the sem.
Fixes issue: #4336
Signed-off-by: Edgar Gabriel [email protected]
sharedfp/sm: unlink only needs to be called by one process
Signed-off-by: Edgar Gabriel [email protected]