Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmix: fix PMIx envar name for the installation prefix. #4004

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

artpol84
Copy link
Contributor

@artpol84 artpol84 commented Aug 2, 2017

Signed-off-by: Artem Polyakov [email protected]

@artpol84
Copy link
Contributor Author

artpol84 commented Aug 2, 2017

Address #3980

@artpol84
Copy link
Contributor Author

artpol84 commented Aug 2, 2017

Per discussion in #3985

@artpol84
Copy link
Contributor Author

artpol84 commented Aug 2, 2017

I've verified that at runtime and master works fine in this case.

@artpol84 artpol84 force-pushed the pmix_instdirs/master branch 2 times, most recently from cfb4a99 to ad98ca5 Compare August 2, 2017 03:38
@artpol84 artpol84 force-pushed the pmix_instdirs/master branch 2 times, most recently from d09df2f to a4e5dc4 Compare August 2, 2017 04:46
@ibm-ompi
Copy link

ibm-ompi commented Aug 2, 2017

The IBM CI (PGI Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6

@artpol84 artpol84 force-pushed the pmix_instdirs/master branch from a4e5dc4 to 71da0fc Compare August 2, 2017 05:07
@artpol84
Copy link
Contributor Author

artpol84 commented Aug 2, 2017

@rhc54 I think this implements solution suggested in #3985 (comment)

@artpol84 artpol84 requested a review from rhc54 August 2, 2017 05:10
@artpol84
Copy link
Contributor Author

artpol84 commented Aug 2, 2017

I verified both at runtime for my case - they solve it

Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why we changed the name down in PMIx, but we did and it doesn't really matter. Thanks!

@rhc54 rhc54 merged commit 355c71b into open-mpi:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants