Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v3.0.x ob1 issues #3852

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Fix v3.0.x ob1 issues #3852

merged 2 commits into from
Jul 17, 2017

Conversation

hjelmn
Copy link
Member

@hjelmn hjelmn commented Jul 12, 2017

No description provided.

hjelmn added 2 commits July 12, 2017 08:42
This commit fixes a bug that occurs when the btl callback happens before
the rget returns. In this case the fragment has been returned and is no
longer valid. This commit saves the size before calling rget. This is
valid since the BTL is not allowed to change the read size.

Fixes open-mpi#3821

Signed-off-by: Nathan Hjelm <[email protected]>
(cherry picked from commit e73ab93)
Signed-off-by: Nathan Hjelm <[email protected]>
This commit ensures that the pml callback is always made when
sending fragments. This is needed to avoid open-mpi#3845. Once that is
fixed the #if 0'd code can be restored.

Signed-off-by: Nathan Hjelm <[email protected]>
(cherry picked from commit c18007d)
Signed-off-by: Nathan Hjelm <[email protected]>
@hjelmn hjelmn added this to the v3.0.0 milestone Jul 12, 2017
@hjelmn hjelmn requested a review from bosilca July 12, 2017 14:43
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it fixed the issue on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants