-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opal/pmix: Bring dstore fixes for rc3 testing #3130
Conversation
d427c15
to
613425b
Compare
@artpol84 Please update this If they ship OMPI before we ship PMIx this will be our record of what the difference might be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artpol84 Please update this README file with a link to the cherry-picked commits:
If they ship OMPI before we ship PMIx this will be our record of what the difference might be.
204a52c
to
841fadb
Compare
Signed-off-by: Paul H. Hargrove <[email protected]> (cherry picked from commit on PMIx v1.2 branch openpmix/openpmix@14f865c)
of `posix_fallocate` check ret code. This refactoring to avoid duplication of code (cherry picked from commit on PMIx v1.2 branch openpmix/openpmix@1b86a6e) Signed-off-by: Boris Karasev <[email protected]>
Signed-off-by: Artem Polyakov <[email protected]>
841fadb
to
f4511f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once it passes CI. Thanks!
CI took forever; this didn't make the nightly snapshot tonight. I might go kick the snapshots after merging this to make another snapshot tonight... |
|
I approved the PR around 3pm US Eastern time. Travis wasn't finished by about 6:30-7pm US Eastern when I had to go offline. I checked again right around 9:30pm US Eastern, and it was done, but that was too late to merge it to get it into the nightly snapshots. I kicked the nightly snapshots again after the first round finished (somewhere around 10:30-11pm US Eastern?), and I see that it finished making another 2.x nightly snapshot at 11:30pm US Eastern. Regardless, Travis's really long CI times (~4+ hours, in this case) are somewhat annoying. |
Signed-off-by: Artem Polyakov [email protected]