Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opal/pmix: Bring dstore fixes for rc3 testing #3130

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

artpol84
Copy link
Contributor

@artpol84 artpol84 commented Mar 8, 2017

@artpol84 artpol84 requested a review from rhc54 March 8, 2017 18:48
@artpol84 artpol84 added this to the v2.1.0 milestone Mar 8, 2017
@artpol84
Copy link
Contributor Author

artpol84 commented Mar 8, 2017

@rhc54

@artpol84 artpol84 changed the title opal/pmix: Bring dstore fixes for rc2 testing opal/pmix: Bring dstore fixes for rc3 testing Mar 8, 2017
@jjhursey
Copy link
Member

jjhursey commented Mar 8, 2017

@artpol84 Please update this README file with a link to the cherry-picked commits:

If they ship OMPI before we ship PMIx this will be our record of what the difference might be.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artpol84 Please update this README file with a link to the cherry-picked commits:

If they ship OMPI before we ship PMIx this will be our record of what the difference might be.

@artpol84 artpol84 force-pushed the dstore_fix/v2.x branch 2 times, most recently from 204a52c to 841fadb Compare March 8, 2017 20:03
PHHargrove and others added 3 commits March 9, 2017 03:06
Signed-off-by: Paul H. Hargrove <[email protected]>
(cherry picked from commit on PMIx v1.2 branch openpmix/openpmix@14f865c)
of `posix_fallocate` check ret code.
This refactoring to avoid duplication of code

(cherry picked from commit on PMIx v1.2 branch openpmix/openpmix@1b86a6e)

Signed-off-by: Boris Karasev <[email protected]>
@artpol84
Copy link
Contributor Author

artpol84 commented Mar 8, 2017

@jsquyres @jjhursey addressed.

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once it passes CI. Thanks!

@jsquyres
Copy link
Member

jsquyres commented Mar 9, 2017

CI took forever; this didn't make the nightly snapshot tonight. I might go kick the snapshots after merging this to make another snapshot tonight...

@jsquyres jsquyres merged commit f0654ce into open-mpi:v2.x Mar 9, 2017
@artpol84
Copy link
Contributor Author

artpol84 commented Mar 9, 2017

CI took forever - @jsquyres what do you mean? It seems to me that it finished in reasonable time.

@jsquyres
Copy link
Member

jsquyres commented Mar 9, 2017

I approved the PR around 3pm US Eastern time. Travis wasn't finished by about 6:30-7pm US Eastern when I had to go offline. I checked again right around 9:30pm US Eastern, and it was done, but that was too late to merge it to get it into the nightly snapshots. I kicked the nightly snapshots again after the first round finished (somewhere around 10:30-11pm US Eastern?), and I see that it finished making another 2.x nightly snapshot at 11:30pm US Eastern.

Regardless, Travis's really long CI times (~4+ hours, in this case) are somewhat annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants