coll/libnbc: Work around for non-uniform data types in ibcast #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If (legal) non-uniform data type signatures are used in ibcast then the chosen algorithm may fail on the request, and worst case it could produce wrong answers. * Add an MCA parameter that, by default, protects the user from this scenario. If the user really wants to use it then they have to 'opt-in' by setting the following parameter to false: - `-mca coll_libnbc_ibcast_skip_dt_decision f` * Once the following Issues are resolved then this parameter can be removed. - open-mpi#2256 - open-mpi#1763 Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 350ef67) Signed-off-by: Joshua Hursey <[email protected]>
|
Fixes #2256 for the |
bosilca
approved these changes
Nov 8, 2016
|
This was merged into v2.0.x, so I'm also merging it here for v2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then the chosen algorithm may fail on the request, and worst case
it could produce wrong answers.
scenario. If the user really wants to use it then they have to
'opt-in' by setting the following parameter to false:
-mca coll_libnbc_ibcast_skip_dt_decision fbe removed.
Signed-off-by: Joshua Hursey [email protected]
(cherry picked from commit 350ef67)
Signed-off-by: Joshua Hursey [email protected]