Silence the libevent warning when a proc abnormally terminates by cleaning up the error registrations #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aning up the error registrations
jsquyres
reviewed
Oct 19, 2016
| peer->index, NULL); | ||
| PMIX_RELEASE(peer); | ||
| /* remove all registered event handlers so libevent doesn't complain */ | ||
| PMIX_LIST_FOREACH_SAFE(reginfoptr, regnext, &pmix_server_globals.client_eventregs, pmix_regevents_info_t) { |
There was a problem hiding this comment.
Do you need a lock around accessing the members of this list? I.e., with a name like "globals", does that imply that another thread may be accessing it at the same time?
There was a problem hiding this comment.
no, we are in an event and therefore safe from any other thread access
jsquyres
approved these changes
Oct 19, 2016
jsquyres
requested changes
Oct 19, 2016
| /* remove all registered event handlers so libevent doesn't complain */ | ||
| PMIX_LIST_FOREACH_SAFE(reginfoptr, regnext, &pmix_server_globals.client_eventregs, pmix_regevents_info_t) { | ||
| if (reginfoptr->peer == peer) { | ||
| PMIX_RELEASE(reginfoptr); |
There was a problem hiding this comment.
Per IM discussion -- @rhc54 is going to bring over another change here for removing the item from the list.
jsquyres
approved these changes
Oct 19, 2016
|
Travis looks kind of borked up again. I'll give it another 30 minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.