v2.1.0: build: Custom libmpi(_FOO) name option in configure #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a configure time option to rename libmpi(_FOO).* - `--with-libmpi-name=STRING` * This commit only impacts the installed libraries. Internal, temporary libraries have not been renamed to limit the scope of the patch to only what is needed. For example: ```shell shell$ ./configure --with-libmpi-name=wookie ... shell$ find . -name "libmpi*" shell$ find . -name "libwookie*" ./lib/libwookie.so.0.0.0 ./lib/libwookie.so.0 ./lib/libwookie.so ./lib/libwookie.la ./lib/libwookie_mpifh.so.0.0.0 ./lib/libwookie_mpifh.so.0 ./lib/libwookie_mpifh.so ./lib/libwookie_mpifh.la ./lib/libwookie_usempi.so.0.0.0 ./lib/libwookie_usempi.so.0 ./lib/libwookie_usempi.so ./lib/libwookie_usempi.la shell$ ``` (cherry picked from commit f6f24a4) Signed-off-by: Joshua Hursey <[email protected]>
|
Refs PR #2059 |
jsquyres
changed the title
|
This is approved in concept (before the Sep 30 deadline for v2.1.0), but there's a bug that needs to be fixed, and I'd like to see this soak on master for at least a day or three to make sure it's correct. |
* In open-mpi/ompi@f6f24a4 I missed updating the library references for the wrapper compilers. * Fixes the CXX wrapper compiler and CXX library is renamed as needed. * Fixes the Java wrapper compiler and the Java library is renamed as needed. (cherry picked from commit fc3cf99) Signed-off-by: Joshua Hursey <[email protected]>
|
@jsquyres The pending bug fix was added to this PR. I is ready for final review. |
jsquyres
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-libmpi-name=STRINGInternal, temporary libraries have not been renamed to limit the
scope of the patch to only what is needed.
For example:
(cherry picked from commit f6f24a4)
Signed-off-by: Joshua Hursey [email protected]