ompi/op: change reduce function prototypes to use a const source pointer #12284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Margolin <[email protected]>
devreal
reviewed
Jan 27, 2024
| @@ -59,20 +59,20 @@ BEGIN_C_DECLS | |||
| * repeated code, but it's better this way (and this typedef will | |||
| * never change, so there's not much of a maintenance worry). | |||
| */ | |||
| typedef void (ompi_op_c_handler_fn_t)(void *, void *, int *, | |||
| typedef void (ompi_op_c_handler_fn_t)(const void *, void *, int *, | |||
There was a problem hiding this comment.
Don't we need to change the signatures of the implementations that are used to set these in ompi_op_t?
There was a problem hiding this comment.
Which ones? I looked for implementations (ompi/mca/op/base/op_base_functions.c for example) and seems to me like all the functions already adhere to this prototype. Maybe I missed some?
There was a problem hiding this comment.
You're right, looks like the build is clean 👍
bosilca
approved these changes
Jan 27, 2024
devreal
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a minor casting fix, found when using GCC v13