[v4.1.x] fix atomic operations opal_atomic_compare_exchange_strong_ in arm64

[yuncliu]

fix opal_atomic_compare_exchange_strong_ bug in arm64

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

4f38ed6: fix atomic operation and spinlock bug

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

4f38ed6: fix atomic operation and spinlock bug

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[jsquyres]

Is this a v4.1.x port of #11999? If so, can you finish the #11999 PR and get that merged first, and then cherry-pick it over here to the v4.1.x branch?

Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

4f38ed6: fix atomic operation and spinlock bug

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2bb9b5b: [arm64] fix atomic strong

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2bb9b5b: [arm64] fix atomic strong

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2bb9b5b: [arm64] fix atomic strong

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[github-actions]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

2bb9b5b: [arm64] fix atomic strong

• check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

[yuncliu]

Is this a v4.1.x port of #11999? If so, can you finish the #11999 PR and get that merged first, and then cherry-pick it over here to the v4.1.x branch?

Thanks!

The main branch only need to modify one file, but 4.1.x need to modify two atomic.h with same implementation, cherry-pick will lost the change in ./opal/include/opal/sys/arm64/atomic.h

[jsquyres]

It looks like we do have a problem here in v4.1.x somewhere, but this is apparently not the desired solution (per discussion on #11999). I'm marking this as "request changes" to ensure we don't merge it, but don't want to close it yet.

#12011 is a new issue opened to track the problem (on main, v5.0.x, and v4.1.x).

[lrbison]

@yuncliu thank you again for reporting this issue. I think it may be fixed in #12338. Can we have any further discussion in the issue #12011 rather than this PR?

I will close this PR for now, as I don't think it is the correct change. However if you could confirm the additional write memory barrier in smcuda fixed your issue #12011 it would be greatly appreciated!

Thank you