Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter name in MPI_Intercomm_merge() #11712

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix parameter name in MPI_Intercomm_merge() #11712

merged 1 commit into from
May 30, 2023

Conversation

ggouaillardet
Copy link
Contributor

Name it newintracomm instead of newintercomm

Thanks Yan Wu for reporting this.

@ggouaillardet
Fix parameter name in MPI_Intercomm_merge()
e07dd3c 
Name it newintracomm instead of newintercomm

Thanks Yan Wu for reporting this.

Signed-off-by: Gilles Gouaillardet <[email protected]>
@ggouaillardet ggouaillardet requested a review from jsquyres May 23, 2023 03:01
jsquyres
jsquyres approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually has implications for the Fortran API (pass by param name); it should definitely get into v5.0.x and potentially even back-ported to v4.1.x.

@jsquyres
Copy link
Member

Looks like this never got merged.

@jsquyres jsquyres merged commit 16e0752 into open-mpi:main May 30, 2023
@jsquyres jsquyres mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres approved these changes

Assignees
No one assigned
Labels
code cleanup fortran bindings Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggouaillardet @jsquyres