romio341: do not include auto-generated file in the dist tarball #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rd-party/romio341/mpl/include/mplconfig.h is automatically generated and hence should not be part of the dist tarball. Refs. open-mpi#10373 Signed-off-by: Gilles Gouaillardet <[email protected]>
|
Did this fix go upstream as well? |
|
no, but the auto-generated file is not in the dist tarball. At this stage, I would consider this as an Open MPI patch (and we have several others for ROMIO) |
awlauria
approved these changes
May 18, 2022
|
Not an expert on romio nor packaging, but this seems straightforward. Is there any reason to not bring this in? |
gpaulsen
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd-party/romio341/mpl/include/mplconfig.h is automatically generated
and hence should not be part of the dist tarball.
Refs. #10373
Signed-off-by: Gilles Gouaillardet [email protected]