-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0: Check for ABI compatibility with v3.1.x #5447
Comments
FYI: @amckinstry |
Thanks for the pointer; this plan makes sense to me. Postponing symbol versioning and adding it in v5.0 would be best. Since symbols will be dropped in v5.0, a new major SOVERSION would be required. |
I have completed this testing. It is important to acknowledge that testing alone can never fully guarantee ABI compatibility. This tested was done in combination with discussion in the weekly web-ex discussions with our core developers and deemed the gating factor if we can keep our .so versions compatible so as to NOT require users' to rebuild/link their mpi applications. I built and ran the open-mpi ibm test suite (generally considered good coverage of the MPI API interface) with top of v3.1.x branch. I then deleted that OpenMPI v3.1.x install, and built Open MPI v4.0.x two time (I repeated this process both with and without the new configure flag:
I was then able to RUN the binaries under each subdirectory of the ibm test suite. PASSED. I will close this issue and create a PR of the VERSION file to v4.0.x that reflects NO need to require customers who built with v3.1.x to recompile/relink with v4.0.0. |
This was done after discussions with core developers about any potential ABI breakage for any of the libs the user directly links against. Also compaitiblity tests were done using the ibm test suite and building with v3.1.x and running with v4.0.x see: open-mpi#5447
This was done after discussions with core developers about any potential ABI breakage for any of the libs the user directly links against. Also compaitiblity tests were done using the ibm test suite and building with v3.1.x and running with v4.0.x see: open-mpi#5447 Signed-off-by: Geoffrey Paulsen <[email protected]>
This was done after discussions with core developers about any potential ABI breakage for any of the libs the user directly links against. Also compaitiblity tests were done using the ibm test suite and building with v3.1.x and running with v4.0.x see: open-mpi#5447 Signed-off-by: Geoffrey Paulsen <[email protected]>
Per 2018-09-11 webex, @gpaulsen says this is now complete / ok to close. |
Per https://www.mail-archive.com/[email protected]/msg00015.html and webex discussion on 2018-07-17, @hppritcha and @gpaulsen will be conducting an ABI compatibility check between the v4.0.x branch (which will be created tomorrow) and the v3.1.x branch.
If possible, we would like to not change libmpi/liboshmem's
.so
major version for all the reasons cited in https://www.mail-archive.com/[email protected]/msg00015.html. We're pretty sure that this means increasing bothc
anda
by 10.Howard and Geoff will need to check the branches manually, and probably do a bunch of testing, such as:
/path
rm -rf /path
c:r:a
values and possibly--enable-mpi1-compat
) into/path
The text was updated successfully, but these errors were encountered: