Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI-4: Bogus typedef and missing definitions and routines related to MPI_Session #10388

Closed
dalcinl opened this issue May 15, 2022 · 7 comments
Closed

MPI-4: Bogus typedef and missing definitions and routines related to MPI_Session #10388

dalcinl opened this issue May 15, 2022 · 7 comments
Assignees
@hppritcha
Labels
MPI-4.0 Severity: blocker Target: main Target: v5.0.x
Milestone
v5.0.0

Comments

@dalcinl
Copy link
Contributor

dalcinl commented May 15, 2022 •
edited
Loading

I'm using branch v5.0.x from git. The changelog claims support for MPI_Session, however I found the following issues:

  • The installed mpi.h header file contains the following line:
typedef int (MPI_Session_delete_attr_function)(MPI_Session, int, void *, void *);

To the best of my knowledge, such typedef is not defined in the MPI-4 standard document. If this typedef comes from an errata or some planned extension, then I apologize for the noise, although I should note it is a bit surprising not seeing a companion MPI_Session_copy_attr_function typedef.

  • The following routines are missing:

    1. MPI_Session_set_errhandler
    2. MPI_Session_get_errhandler
    3. MPI_Session_call_errhandler

    Note however that MPI_Session_create_errhandler is available.

  • The MPI_ERR_SESSION error class is missing (MPI-4, pp. 472, ln. 28). It should be used for in all of the MPI_Session_XXX routines to signal an invalid MPI_Session argument.

  • The MPI_Info_create_env routine is missing.
    Although not strictly related to the MPI_Session type, the MPI_Info_create_env routine is the way to get something equivalent to MPI_INFO_ENV when using the Session model (MPI-4, pp. 484, ln. 35)
@dalcinl dalcinl changed the title MPI_Session: Bogus typedef and missing errhandler routines MPI-4: Bogus typedef and missing definitions and routines related to MPI_Session May 16, 2022
@awlauria awlauria added this to the v5.0.0 milestone May 16, 2022
@hppritcha hppritcha self-assigned this May 16, 2022
@hppritcha
Copy link
Member

related to #7993

hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 1, 2022
@hppritcha
sessions: add missing errhandler funcs
28590f8 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 2, 2022
@hppritcha
sessions: add missing errhandler funcs
508a7bb 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 2, 2022
@hppritcha
sessions: add missing errhandler funcs
4402736 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 2, 2022
@hppritcha
sessions: add missing errhandler funcs
01446b9 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 2, 2022
@hppritcha
sessions: add missing errhandler funcs
8894ff0 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Related to open-mpi#9097

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha mentioned this issue Jun 2, 2022
Merged
@dalcinl
Copy link
Contributor Author

dalcinl commented Jun 3, 2022

This issue should be labeled as MPI-4.0.

hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 21, 2022
@hppritcha
sessions: remove sessions attr del function def
78c5a03 
The sessions attribute functionality was never approved as part of the MPI-4 sessions feature.
Remove a vestige of this from Open MPI.

Related to open-mpi#10388

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 21, 2022
@hppritcha
sessions: remove sessions attr del function def
c488c60 
The sessions attribute functionality was never approved as part of the MPI-4 sessions feature.
Remove a vestige of this from Open MPI.

Related to open-mpi#10388
Related to open-mpi#9097

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha hppritcha mentioned this issue Jun 21, 2022
Merged
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 22, 2022
@hppritcha
sessions: remove sessions attr del function def
ab8aca7 
The sessions attribute functionality was never approved as part of the MPI-4 sessions feature.
Remove a vestige of this from Open MPI.

Related to open-mpi#10388
Related to open-mpi#9097

Signed-off-by: Howard Pritchard <[email protected]>
(cherry picked from commit c488c60)
@hppritcha hppritcha mentioned this issue Jun 22, 2022
Merged
hppritcha added a commit to hppritcha/ompi that referenced this issue Jun 24, 2022
@hppritcha
sessions: add missing errhandler funcs
e5c3795 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Related to open-mpi#9097

Signed-off-by: Howard Pritchard <[email protected]>
hppritcha added a commit to hppritcha/ompi that referenced this issue Jul 11, 2022
@hppritcha
sessions: add missing errhandler funcs
eecad9b 
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.

Related to open-mpi#10388

Related to open-mpi#9097

Signed-off-by: Howard Pritchard <[email protected]>
(cherry picked from commit e5c3795)
@hppritcha hppritcha mentioned this issue Jul 11, 2022
Merged
@awlauria
Copy link
Contributor

merged to main and v5.0.x, closing. Thanks @hppritcha

@dalcinl
Copy link
Contributor Author

dalcinl commented Jul 18, 2022

@awlauria This issue is not completed, see the last two bullet points in the description.

  • The MPI_Info_create_env routine is missing, although this is already tracked in implement MPI_INFO_CREATE_ENV #7993.
  • The MPI_ERR_SESSION error class is still missing. Perhaps this should be tracked in a new issue?

@jsquyres
Copy link
Member

@awlauria Do you want to re-open this?

The MPI_ERR_SESSION issue is being tracked at #10588

@jsquyres
Copy link
Member

Oh, I can re-open it. Duh. 😄

@jsquyres jsquyres reopened this Jul 21, 2022
@dalcinl
Copy link
Contributor Author

dalcinl commented Jul 21, 2022

Oh, I can re-open it. Duh.

As there is another issue tracking the leftover, you can re-close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hppritcha hppritcha

Labels
MPI-4.0 Severity: blocker Target: main Target: v5.0.x
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
4 participants
@dalcinl @jsquyres @hppritcha @awlauria