-
Notifications
You must be signed in to change notification settings - Fork 69
v2.x: oshmem: Align OSHMEM API with spec v1.3 (alltoall) #1042
Conversation
Test PASSed. |
This isn't a bug fix. Only bug fixes going in to 2.0.0 now. Moving to 2.1 milestone. |
👍 |
ffab133
to
09b1ac8
Compare
09b1ac8
to
f3b7e4a
Compare
Test PASSed. |
Test PASSed. |
@@ -245,6 +245,10 @@ OSHMEM_DECLSPEC void pshmem_collect32(void *target, const void *source, size_t n | |||
OSHMEM_DECLSPEC void pshmem_collect64(void *target, const void *source, size_t nlong, int PE_start, int logPE_stride, int PE_size, long *pSync); | |||
OSHMEM_DECLSPEC void pshmem_fcollect32(void *target, const void *source, size_t nlong, int PE_start, int logPE_stride, int PE_size, long *pSync); | |||
OSHMEM_DECLSPEC void pshmem_fcollect64(void *target, const void *source, size_t nlong, int PE_start, int logPE_stride, int PE_size, long *pSync); | |||
OSHMEM_DECLSPEC void pshmem_alltoall32(void *target, const void *source, size_t nelems, int PE_start, int logPE_stride, int PE_size, long *pSync); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did not see that in master, so i committed it in open-mpi/ompi@cb84f58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggouaillardet you are right. I noticed it too yesterday but forgot to push. Thank you.
bot:mellanox:retest |
Test PASSed. |
@artpol84 as a sanity check, are there any dependencies of this PR on other oshmem PR's going in to 2.1? |
@hppritcha - shouldn't be as nothing was indicated in the title/comments of this PR. |
trunk: open-mpi/ompi#1478
:bot:assign: @hppritcha
:bot🏷️enhancement
:bot:milestone:v2.0.0
open-mpi/ompi@50906b3
open-mpi/ompi@bd6eaac
open-mpi/ompi@3e1e131
open-mpi/ompi@9825157
open-mpi/ompi@1bed5d8